luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

examples/cookie_interface: avoid printfing time_t directly

Browse Source 
time_t representation is undefined and varies on bitsize and signedness,
and as of C11 could be even non integer.

instead of casting to unsigned long (which would truncate in systems
with a 32bit long after 2106) use difftime to get the elapsed time as a
double and print that (without decimals) instead.

alternatively a cast to curl_off_t and its corresponding print
formatting could have been used (at least in POSIX) but portability and
curl agnostic code was prioritized.

Closes #7490
This commit is contained in:
Carlo Marcelo Arenas Belón 2021-07-24 11:54:30 -07:00 committed by Daniel Stenberg
parent 4a7bf79fcc
commit 4b79c4fb56
No known key found for this signature in database
GPG Key ID: 5CC908FDB71E12C2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/examples/cookie_interface.c
View File

@ -93,9 +93,9 @@ main(void)
#define snprintf _snprintf #define snprintf _snprintf
#endif #endif
/* Netscape format cookie */ /* Netscape format cookie */
snprintf(nline, sizeof(nline), "%s\t%s\t%s\t%s\t%lu\t%s\t%s", snprintf(nline, sizeof(nline), "%s\t%s\t%s\t%s\t%.0lf\t%s\t%s",
".example.com", "TRUE", "/", "FALSE", ".example.com", "TRUE", "/", "FALSE",
(unsigned long)time(NULL) + 31337UL, difftime(time(NULL) + 31337, (time_t)0),
"PREF", "hello example, i like you very much!"); "PREF", "hello example, i like you very much!");
res = curl_easy_setopt(curl, CURLOPT_COOKIELIST, nline); res = curl_easy_setopt(curl, CURLOPT_COOKIELIST, nline);
if(res != CURLE_OK) { if(res != CURLE_OK) {