luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use a slightly clearer name

Browse Source 
Co-authored-by: 9291Sam <sam.skinr@gmail.com>
This commit is contained in:
Jeremy Rifkin 2025-02-19 21:04:58 -06:00
parent d6fff9022e
commit 2bb29f71bc
No known key found for this signature in database
GPG Key ID: 19AA8270105E8EB4
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/platform/dbghelp_utils.cpp
View File

@ -105,16 +105,16 @@ namespace detail {
// SymInitialize being called twice. // SymInitialize being called twice.
// DuplicateHandle requires the PROCESS_DUP_HANDLE access right. If for some reason DuplicateHandle we fall back // DuplicateHandle requires the PROCESS_DUP_HANDLE access right. If for some reason DuplicateHandle we fall back
// to calling SymInitialize on the process handle. // to calling SymInitialize on the process handle.
optional<DWORD> duplicate_handle_errored; optional<DWORD> maybe_duplicate_handle_error_code;
if(!DuplicateHandle(proc, proc, proc, &duplicated_handle.get(), 0, FALSE, DUPLICATE_SAME_ACCESS)) { if(!DuplicateHandle(proc, proc, proc, &duplicated_handle.get(), 0, FALSE, DUPLICATE_SAME_ACCESS)) {
duplicate_handle_errored = GetLastError(); maybe_duplicate_handle_error_code = GetLastError();
} }
if(!SymInitialize(duplicate_handle_errored ? proc : duplicated_handle.get(), NULL, TRUE)) { if(!SymInitialize(maybe_duplicate_handle_error_code ? proc : duplicated_handle.get(), NULL, TRUE)) {
if(duplicate_handle_errored) { if(maybe_duplicate_handle_error_code) {
throw internal_error( throw internal_error(
"SymInitialize failed with error code {} after DuplicateHandle failed with error code {}", "SymInitialize failed with error code {} after DuplicateHandle failed with error code {}",
GetLastError(), GetLastError(),
duplicate_handle_errored.unwrap() maybe_duplicate_handle_error_code.unwrap()
); );
} else { } else {
throw internal_error("SymInitialize failed with error code {}", GetLastError()); throw internal_error("SymInitialize failed with error code {}", GetLastError());
@ -122,8 +122,8 @@ namespace detail {
} }
auto info = dbghelp_syminit_info::make_owned( auto info = dbghelp_syminit_info::make_owned(
duplicate_handle_errored ? proc : exchange(duplicated_handle.get(), nullptr), maybe_duplicate_handle_error_code ? proc : exchange(duplicated_handle.get(), nullptr),
duplicate_handle_errored ? false : true // looks funny but I think it's a little more expressive !maybe_duplicate_handle_error_code
); );
// either cache and return a view or return the owning wrapper // either cache and return a view or return the owning wrapper
if(get_cache_mode() == cache_mode::prioritize_speed) { if(get_cache_mode() == cache_mode::prioritize_speed) {