luo980/cpptrace
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add quick note

Browse Source
This commit is contained in:
Jeremy 2023-07-24 21:56:37 -04:00
parent 72228ab5e8
commit 144ab89871
No known key found for this signature in database
GPG Key ID: 19AA8270105E8EB4
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/platform/elf.hpp
View File

@ -20,6 +20,9 @@ T elf_byteswap_if_needed(T value, bool elf_is_little) {
} }
} }
// TODO: Address code duplication here. Do we actually have to care about 32-bit if the library is compiled as 64-bit?
// I think probably not...
// TODO: Re-evaluate use of off_t // TODO: Re-evaluate use of off_t
// I think we can rely on PT_PHDR https://stackoverflow.com/q/61568612/15675011... // I think we can rely on PT_PHDR https://stackoverflow.com/q/61568612/15675011...
static uintptr_t elf_get_module_image_base_from_program_table( static uintptr_t elf_get_module_image_base_from_program_table(