From 144ab8987168f040c904bb089632003e0250f1dd Mon Sep 17 00:00:00 2001 From: Jeremy <51220084+jeremy-rifkin@users.noreply.github.com> Date: Mon, 24 Jul 2023 21:56:37 -0400 Subject: [PATCH] Add quick note --- src/platform/elf.hpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/platform/elf.hpp b/src/platform/elf.hpp index 7d78a97..2e9c73f 100644 --- a/src/platform/elf.hpp +++ b/src/platform/elf.hpp @@ -20,6 +20,9 @@ T elf_byteswap_if_needed(T value, bool elf_is_little) { } } +// TODO: Address code duplication here. Do we actually have to care about 32-bit if the library is compiled as 64-bit? +// I think probably not... + // TODO: Re-evaluate use of off_t // I think we can rely on PT_PHDR https://stackoverflow.com/q/61568612/15675011... static uintptr_t elf_get_module_image_base_from_program_table(