luo980/yaml-cpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[clang-tidy] remove pointless const

Browse Source 
Found with readability-const-return-type

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-06-15 15:18:19 -07:00
parent a6bbe0e50a
commit be7492203e
8 changed files with 12 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
include/yaml-cpp/emitter.h
View File

@ -44,7 +44,7 @@ class YAML_CPP_API Emitter {
// state checking
bool good() const;
const std::string GetLastError() const;
std::string GetLastError() const;
// global setters
bool SetOutputCharset(EMITTER_MANIP value);

3
src/directives.cpp
View File

@ -3,8 +3,7 @@
namespace YAML {
Directives::Directives() : version{true, 1, 2}, tags{} {}
const std::string Directives::TranslateTagHandle(
const std::string& handle) const {
std::string Directives::TranslateTagHandle(const std::string& handle) const {
auto it = tags.find(handle);
if (it == tags.end()) {
if (handle == "!!")

2
src/directives.h
View File

@ -19,7 +19,7 @@ struct Version {
struct Directives {
Directives();
const std::string TranslateTagHandle(const std::string& handle) const;
std::string TranslateTagHandle(const std::string& handle) const;
Version version;
std::map<std::string, std::string> tags;

4
src/emitter.cpp
View File

@ -25,9 +25,7 @@ std::size_t Emitter::size() const { return m_stream.pos(); }
// state checking
bool Emitter::good() const { return m_pState->good(); }
const std::string Emitter::GetLastError() const {
return m_pState->GetLastError();
}
std::string Emitter::GetLastError() const { return m_pState->GetLastError(); }
// global setters
bool Emitter::SetOutputCharset(EMITTER_MANIP value) {

6
src/scantag.cpp
View File

@ -6,7 +6,7 @@
#include "yaml-cpp/mark.h"
namespace YAML {
const std::string ScanVerbatimTag(Stream& INPUT) {
std::string ScanVerbatimTag(Stream& INPUT) {
std::string tag;
// eat the start character
@ -29,7 +29,7 @@ const std::string ScanVerbatimTag(Stream& INPUT) {
throw ParserException(INPUT.mark(), ErrorMsg::END_OF_VERBATIM_TAG);
}
const std::string ScanTagHandle(Stream& INPUT, bool& canBeHandle) {
std::string ScanTagHandle(Stream& INPUT, bool& canBeHandle) {
std::string tag;
canBeHandle = true;
Mark firstNonWordChar;
@ -62,7 +62,7 @@ const std::string ScanTagHandle(Stream& INPUT, bool& canBeHandle) {
return tag;
}
const std::string ScanTagSuffix(Stream& INPUT) {
std::string ScanTagSuffix(Stream& INPUT) {
std::string tag;
while (INPUT) {

6
src/scantag.h
View File

@ -11,9 +11,9 @@
#include "stream.h"
namespace YAML {
const std::string ScanVerbatimTag(Stream& INPUT);
const std::string ScanTagHandle(Stream& INPUT, bool& canBeHandle);
const std::string ScanTagSuffix(Stream& INPUT);
std::string ScanVerbatimTag(Stream& INPUT);
std::string ScanTagHandle(Stream& INPUT, bool& canBeHandle);
std::string ScanTagSuffix(Stream& INPUT);
}
#endif // SCANTAG_H_62B23520_7C8E_11DE_8A39_0800200C9A66

2
src/tag.cpp
View File

@ -29,7 +29,7 @@ Tag::Tag(const Token& token)
}
}
const std::string Tag::Translate(const Directives& directives) {
std::string Tag::Translate(const Directives& directives) {
switch (type) {
case VERBATIM:
return value;

2
src/tag.h
View File

@ -23,7 +23,7 @@ struct Tag {
};
Tag(const Token& token);
const std::string Translate(const Directives& directives);
std::string Translate(const Directives& directives);
TYPE type;
std::string handle, value;