luo980/yaml-cpp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cppcheck] use find_if

Browse Source 
Found with useStlAlgorithm

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2020-06-02 21:58:39 -07:00
parent 33c9f6e062
commit 740293fda4
No known key found for this signature in database
GPG Key ID: 36D31CFA845F0E3B
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/node_data.cpp
View File

@ -1,3 +1,4 @@
#include <algorithm>
#include <cassert>
#include <iterator>
#include <sstream>
@ -209,12 +210,10 @@ node* node_data::get(node& key, shared_memory_holder /* pMemory */) const {
return nullptr;
}
for (const auto& it : m_map) {
if (it.first->is(key))
return it.second;
}
return nullptr;
auto it = std::find_if(
m_map.begin(), m_map.end(),
[&](const std::pair<node*, node*> node) { return node.first->is(key); });
return it != m_map.end() ? it->second : nullptr;
}
node& node_data::get(node& key, shared_memory_holder pMemory) {
@ -230,9 +229,11 @@ node& node_data::get(node& key, shared_memory_holder pMemory) {
throw BadSubscript(m_mark, key);
}
for (const auto& it : m_map) {
if (it.first->is(key))
return *it.second;
auto it = std::find_if(
m_map.begin(), m_map.end(),
[&](const std::pair<node*, node*> node) { return node.first->is(key); });
if (it != m_map.end()) {
return *it->second;
}
node& value = pMemory->create_node();