luo980/uvw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "more tests"

Browse Source 
This reverts commit 434a602fa7.
This commit is contained in:
Michele Caini 2022-04-07 18:37:18 +02:00
parent 3adf0f3579
commit 7c50874422
3 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/uvw/fs_event.cpp
View File

@ -31,8 +31,9 @@ UVW_INLINE void fs_event_handle::start(const std::string &path, event_flags flag
} }
UVW_INLINE void fs_event_handle::stop() { UVW_INLINE void fs_event_handle::stop() {
// uv_fs_event_stop never returns a value other than 0 apparently if(auto err = uv_fs_event_stop(raw()); err != 0) {
uv_fs_event_stop(raw()); publish(error_event{err});
}
} }
UVW_INLINE std::string fs_event_handle::path() UVW_NOEXCEPT { UVW_INLINE std::string fs_event_handle::path() UVW_NOEXCEPT {

2
src/uvw/timer.cpp
View File

@ -22,7 +22,7 @@ UVW_INLINE void timer_handle::start(timer_handle::time timeout, timer_handle::ti
} }
UVW_INLINE void timer_handle::stop() { UVW_INLINE void timer_handle::stop() {
// uv_timer_stop never returns a value other than 0 apparently // uv_timer_stop never returns 0 apparently
uv_timer_stop(raw()); uv_timer_stop(raw());
} }

14
test/uvw/fs_event.cpp
View File

@ -9,13 +9,10 @@ TEST(FsEvent, Functionalities) {
auto handle = loop->resource<uvw::fs_event_handle>(); auto handle = loop->resource<uvw::fs_event_handle>();
auto request = loop->resource<uvw::file_req>(); auto request = loop->resource<uvw::file_req>();
bool checkErrorEvent = false;
bool checkFsEventEvent = false; bool checkFsEventEvent = false;
handle->on<uvw::error_event>([&](const auto &, auto &) { handle->on<uvw::error_event>([](const auto &, auto &) { FAIL(); });
ASSERT_FALSE(checkErrorEvent); request->on<uvw::error_event>([](const auto &, auto &) { FAIL(); });
checkErrorEvent = true;
});
handle->on<uvw::fs_event_event>([&checkFsEventEvent](const auto &event, auto &hndl) { handle->on<uvw::fs_event_event>([&checkFsEventEvent](const auto &event, auto &hndl) {
ASSERT_FALSE(checkFsEventEvent); ASSERT_FALSE(checkFsEventEvent);
@ -26,8 +23,6 @@ TEST(FsEvent, Functionalities) {
ASSERT_TRUE(hndl.closing()); ASSERT_TRUE(hndl.closing());
}); });
request->on<uvw::error_event>([](const auto &, auto &) { FAIL(); });
request->on<uvw::fs_event>([&](const auto &event, auto &req) { request->on<uvw::fs_event>([&](const auto &event, auto &req) {
switch(event.type) { switch(event.type) {
case uvw::fs_req::fs_type::WRITE: case uvw::fs_req::fs_type::WRITE:
@ -50,11 +45,6 @@ TEST(FsEvent, Functionalities) {
ASSERT_TRUE(handle->active()); ASSERT_TRUE(handle->active());
ASSERT_FALSE(handle->closing()); ASSERT_FALSE(handle->closing());
handle->start(std::string{TARGET_FS_EVENT_DIR}, uvw::fs_event_handle::event_flags::RECURSIVE);
ASSERT_TRUE(checkErrorEvent);
ASSERT_FALSE(checkFsEventEvent);
loop->run(); loop->run();
ASSERT_TRUE(checkFsEventEvent); ASSERT_TRUE(checkFsEventEvent);