cleanup

src/uvw/lib.hpp

@@ -28,7 +28,7 @@ public:
      * @return A pointer to the newly created handle.
      */
     explicit SharedLib(ConstructorAccess ca, std::shared_ptr<Loop> ref, std::string filename) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         opened = (0 == uv_dlopen(filename.data(), get()));
     }

src/uvw/pipe.hpp

@@ -29,7 +29,7 @@ namespace uvw {
 class PipeHandle final: public StreamHandle<PipeHandle, uv_pipe_t> {
 public:
     explicit PipeHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref, bool pass = false)
-        : StreamHandle{std::move(ca), std::move(ref)}, ipc{pass}
+        : StreamHandle{ca, std::move(ref)}, ipc{pass}
     {}
 
     /**

src/uvw/poll.hpp

@@ -75,11 +75,11 @@ public:
     using Event = details::UVPollEvent;
 
     explicit PollHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref, int desc)
-        : Handle{std::move(ca), std::move(ref)}, tag{FD}, fd{desc}
+        : Handle{ca, std::move(ref)}, tag{FD}, fd{desc}
     {}
 
     explicit PollHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref, OSSocketHandle sock)
-        : Handle{std::move(ca), std::move(ref)}, tag{SOCKET}, socket{sock}
+        : Handle{ca, std::move(ref)}, tag{SOCKET}, socket{sock}
     {}
 
     /**

src/uvw/process.hpp

@@ -72,7 +72,7 @@ public:
     using StdIO = details::UVStdIOFlags;
 
     ProcessHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref)
-        : Handle{std::move(ca), std::move(ref)}, poFdStdio{1}
+        : Handle{ca, std::move(ref)}, poFdStdio{1}
     {
         // stdin container default initialization
         poFdStdio[0].flags = static_cast<uv_stdio_flags>(StdIO::IGNORE_STREAM);

src/uvw/resource.hpp

@@ -38,7 +38,7 @@ protected:
 
 public:
     explicit Resource(ConstructorAccess ca, std::shared_ptr<Loop> ref)
-        : UnderlyingType<T, U>{std::move(ca), std::move(ref)},
+        : UnderlyingType<T, U>{ca, std::move(ref)},
           Emitter<T>{},
           std::enable_shared_from_this<T>{}
     {

src/uvw/stream.hpp

@@ -97,7 +97,7 @@ public:
     using Deleter = void(*)(char *);
 
     WriteReq(ConstructorAccess ca, std::shared_ptr<Loop> loop, std::unique_ptr<char[], Deleter> dt, unsigned int len)
-        : Request<WriteReq, uv_write_t>{std::move(ca), std::move(loop)},
+        : Request<WriteReq, uv_write_t>{ca, std::move(loop)},
           data{std::move(dt)},
           buf{uv_buf_init(data.get(), len)}
     {}
@@ -156,7 +156,7 @@ class StreamHandle: public Handle<T, U> {
 public:
 #ifdef _WIN32
     StreamHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref)
-        : Handle{std::move(ca), std::move(ref)}
+        : Handle{ca, std::move(ref)}
     {}
 #else
     using Handle<T, U>::Handle;

src/uvw/tcp.hpp

@@ -52,7 +52,7 @@ public:
     using StreamHandle::StreamHandle;
 
     explicit TcpHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref, unsigned int f)
-        : StreamHandle{std::move(ca), std::move(ref)}, tag{FLAGS}, flags{f}
+        : StreamHandle{ca, std::move(ref)}, tag{FLAGS}, flags{f}
     {}
 
     /**

src/uvw/thread.hpp

@@ -36,7 +36,7 @@ public:
     using Type = uv_thread_t;
 
     explicit Thread(ConstructorAccess ca, std::shared_ptr<Loop> ref, InternalTask t, std::shared_ptr<void> d = nullptr) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}, data{std::move(d)}, task{std::move(t)}
+        : UnderlyingType{ca, std::move(ref)}, data{std::move(d)}, task{std::move(t)}
     {}
 
     static Type self() noexcept {
@@ -68,7 +68,7 @@ private:
 class ThreadLocalStorage final: public UnderlyingType<ThreadLocalStorage, uv_key_t> {
 public:
     explicit ThreadLocalStorage(ConstructorAccess ca, std::shared_ptr<Loop> ref) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         uv_key_create(UnderlyingType::get());
     }
@@ -114,7 +114,7 @@ class Mutex final: public UnderlyingType<Mutex, uv_mutex_t> {
 
 public:
     explicit Mutex(ConstructorAccess ca, std::shared_ptr<Loop> ref) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         uv_mutex_init(get());
     }
@@ -140,7 +140,7 @@ public:
 class RWLock final: public UnderlyingType<RWLock, uv_rwlock_t> {
 public:
     explicit RWLock(ConstructorAccess ca, std::shared_ptr<Loop> ref) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         uv_rwlock_init(get());
     }
@@ -178,7 +178,7 @@ public:
 class Semaphore final: public UnderlyingType<Semaphore, uv_sem_t> {
 public:
     explicit Semaphore(ConstructorAccess ca, std::shared_ptr<Loop> ref, unsigned int value) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         uv_sem_init(get(), value);
     }
@@ -204,7 +204,7 @@ public:
 class Condition final: public UnderlyingType<Condition, uv_cond_t> {
 public:
     explicit Condition(ConstructorAccess ca, std::shared_ptr<Loop> ref) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         uv_cond_init(get());
     }
@@ -234,7 +234,7 @@ public:
 class Barrier final: public UnderlyingType<Barrier, uv_barrier_t> {
 public:
     explicit Barrier(ConstructorAccess ca, std::shared_ptr<Loop> ref, unsigned int count) noexcept
-        : UnderlyingType{std::move(ca), std::move(ref)}
+        : UnderlyingType{ca, std::move(ref)}
     {
         uv_barrier_init(get(), count);
     }

src/uvw/tty.hpp

@@ -61,7 +61,7 @@ public:
     using Mode = details::UVTTYModeT;
 
     explicit TTYHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref, FileHandle desc, bool readable)
-        : StreamHandle{std::move(ca), std::move(ref)},
+        : StreamHandle{ca, std::move(ref)},
           memo{resetModeMemo()},
           fd{desc},
           rw{readable}

src/uvw/udp.hpp

@@ -62,7 +62,7 @@ public:
     using Deleter = void(*)(char *);
 
     SendReq(ConstructorAccess ca, std::shared_ptr<Loop> loop, std::unique_ptr<char[], Deleter> dt, unsigned int len)
-        : Request<SendReq, uv_udp_send_t>{std::move(ca), std::move(loop)},
+        : Request<SendReq, uv_udp_send_t>{ca, std::move(loop)},
           data{std::move(dt)},
           buf{uv_buf_init(data.get(), len)}
     {}
@@ -128,7 +128,7 @@ public:
     using Handle::Handle;
 
     explicit UDPHandle(ConstructorAccess ca, std::shared_ptr<Loop> ref, unsigned int f)
-        : Handle{std::move(ca), std::move(ref)}, tag{FLAGS}, flags{f}
+        : Handle{ca, std::move(ref)}, tag{FLAGS}, flags{f}
     {}
 
     /**

src/uvw/work.hpp

@@ -45,7 +45,7 @@ public:
     using Task = InternalTask;
 
     explicit WorkReq(ConstructorAccess ca, std::shared_ptr<Loop> ref, InternalTask t)
-        : Request{std::move(ca), std::move(ref)}, task{t}
+        : Request{ca, std::move(ref)}, task{t}
     {}
 
     /**