luo980/uvw
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #68 from tusharpm/master

Browse Source 
Replaced `for` loop as mentioned in comment
This commit is contained in:
Michele Caini 2016-10-16 15:55:52 +02:00 committed by GitHub
commit 3ef86aea06
3 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/uvw/stream.hpp
View File

@ -118,9 +118,7 @@ class WriteReq final: public Request<WriteReq, uv_write_t> {
bufs{new uv_buf_t[N], &deleter<N>}, bufs{new uv_buf_t[N], &deleter<N>},
nbufs{N} nbufs{N}
{ {
for(std::size_t i = 0; i < N; ++i) { std::copy_n(std::begin(arr), N, bufs.get());
bufs[i] = arr[i];
}
} }
public: public:

5
src/uvw/udp.hpp
View File

@ -3,6 +3,7 @@
#include <type_traits> #include <type_traits>
#include <algorithm> #include <algorithm>
#include <iterator>
#include <utility> #include <utility>
#include <cstddef> #include <cstddef>
#include <memory> #include <memory>
@ -72,9 +73,7 @@ class SendReq final: public Request<SendReq, uv_udp_send_t> {
bufs{new uv_buf_t[N], &deleter<N>}, bufs{new uv_buf_t[N], &deleter<N>},
nbufs{N} nbufs{N}
{ {
for(std::size_t i = 0; i < N; ++i) { std::copy_n(std::begin(arr), N, bufs.get());
bufs[i] = arr[i];
}
} }
public: public:

9
test/uvw/loop.cpp
View File

@ -2,7 +2,7 @@
#include <uvw.hpp> #include <uvw.hpp>
TEST(Loop, PartiallyDone) { TEST(Loop, DefaultLoop) {
auto def = uvw::Loop::getDefault(); auto def = uvw::Loop::getDefault();
ASSERT_TRUE(static_cast<bool>(def)); ASSERT_TRUE(static_cast<bool>(def));
@ -11,6 +11,13 @@ TEST(Loop, PartiallyDone) {
def->walk([](uvw::BaseHandle &) { FAIL(); }); def->walk([](uvw::BaseHandle &) { FAIL(); });
auto def2 = uvw::Loop::getDefault();
ASSERT_EQ(def, def2);
}
TEST(Loop, PartiallyDone) {
auto loop = uvw::Loop::create(); auto loop = uvw::Loop::create();
auto handle = loop->resource<uvw::PrepareHandle>(); auto handle = loop->resource<uvw::PrepareHandle>();
auto req = loop->resource<uvw::WorkReq>([]{}); auto req = loop->resource<uvw::WorkReq>([]{});