Libuv does not support multiple handles watching the same file descriptor. That condition is caught by an assert but it's detached from the call site and therefore not always trivial to track down. This commit turns cases where we can easily detect duplicates into runtime `UV_EEXIST` errors. More work is needed to catch _all_ cases. Partially addresses https://github.com/libuv/libuv/issues/1172. PR-URL: https://github.com/libuv/libuv/pull/1851 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
218 lines
4.7 KiB
C
218 lines
4.7 KiB
C
/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "uv.h"
|
|
#include "task.h"
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#ifndef _WIN32
|
|
# include <unistd.h>
|
|
#endif
|
|
|
|
static int send_cb_called = 0;
|
|
static int close_cb_called = 0;
|
|
|
|
static uv_udp_send_t send_req;
|
|
|
|
|
|
static void startup(void) {
|
|
#ifdef _WIN32
|
|
struct WSAData wsa_data;
|
|
int r = WSAStartup(MAKEWORD(2, 2), &wsa_data);
|
|
ASSERT(r == 0);
|
|
#endif
|
|
}
|
|
|
|
|
|
static uv_os_sock_t create_udp_socket(void) {
|
|
uv_os_sock_t sock;
|
|
|
|
sock = socket(AF_INET, SOCK_DGRAM, IPPROTO_IP);
|
|
#ifdef _WIN32
|
|
ASSERT(sock != INVALID_SOCKET);
|
|
#else
|
|
ASSERT(sock >= 0);
|
|
#endif
|
|
|
|
#ifndef _WIN32
|
|
{
|
|
/* Allow reuse of the port. */
|
|
int yes = 1;
|
|
int r = setsockopt(sock, SOL_SOCKET, SO_REUSEADDR, &yes, sizeof yes);
|
|
ASSERT(r == 0);
|
|
}
|
|
#endif
|
|
|
|
return sock;
|
|
}
|
|
|
|
|
|
static void close_socket(uv_os_sock_t sock) {
|
|
int r;
|
|
#ifdef _WIN32
|
|
r = closesocket(sock);
|
|
#else
|
|
r = close(sock);
|
|
#endif
|
|
ASSERT(r == 0);
|
|
}
|
|
|
|
|
|
static void alloc_cb(uv_handle_t* handle,
|
|
size_t suggested_size,
|
|
uv_buf_t* buf) {
|
|
static char slab[65536];
|
|
ASSERT(suggested_size <= sizeof(slab));
|
|
buf->base = slab;
|
|
buf->len = sizeof(slab);
|
|
}
|
|
|
|
|
|
static void close_cb(uv_handle_t* handle) {
|
|
ASSERT(handle != NULL);
|
|
close_cb_called++;
|
|
}
|
|
|
|
|
|
static void recv_cb(uv_udp_t* handle,
|
|
ssize_t nread,
|
|
const uv_buf_t* buf,
|
|
const struct sockaddr* addr,
|
|
unsigned flags) {
|
|
int r;
|
|
|
|
if (nread < 0) {
|
|
ASSERT(0 && "unexpected error");
|
|
}
|
|
|
|
if (nread == 0) {
|
|
/* Returning unused buffer. Don't count towards sv_recv_cb_called */
|
|
ASSERT(addr == NULL);
|
|
return;
|
|
}
|
|
|
|
ASSERT(flags == 0);
|
|
|
|
ASSERT(addr != NULL);
|
|
ASSERT(nread == 4);
|
|
ASSERT(memcmp("PING", buf->base, nread) == 0);
|
|
|
|
r = uv_udp_recv_stop(handle);
|
|
ASSERT(r == 0);
|
|
|
|
uv_close((uv_handle_t*) handle, close_cb);
|
|
}
|
|
|
|
|
|
static void send_cb(uv_udp_send_t* req, int status) {
|
|
ASSERT(req != NULL);
|
|
ASSERT(status == 0);
|
|
|
|
send_cb_called++;
|
|
}
|
|
|
|
|
|
TEST_IMPL(udp_open) {
|
|
struct sockaddr_in addr;
|
|
uv_buf_t buf = uv_buf_init("PING", 4);
|
|
uv_udp_t client;
|
|
uv_os_sock_t sock;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("127.0.0.1", TEST_PORT, &addr));
|
|
|
|
startup();
|
|
sock = create_udp_socket();
|
|
|
|
r = uv_udp_init(uv_default_loop(), &client);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_open(&client, sock);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_bind(&client, (const struct sockaddr*) &addr, 0);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_recv_start(&client, alloc_cb, recv_cb);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_send(&send_req,
|
|
&client,
|
|
&buf,
|
|
1,
|
|
(const struct sockaddr*) &addr,
|
|
send_cb);
|
|
ASSERT(r == 0);
|
|
|
|
#ifndef _WIN32
|
|
{
|
|
uv_udp_t client2;
|
|
|
|
r = uv_udp_init(uv_default_loop(), &client2);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_open(&client2, sock);
|
|
ASSERT(r == UV_EEXIST);
|
|
|
|
uv_close((uv_handle_t*) &client2, NULL);
|
|
}
|
|
#endif /* !_WIN32 */
|
|
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
ASSERT(send_cb_called == 1);
|
|
ASSERT(close_cb_called == 1);
|
|
|
|
ASSERT(client.send_queue_size == 0);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(udp_open_twice) {
|
|
uv_udp_t client;
|
|
uv_os_sock_t sock1, sock2;
|
|
int r;
|
|
|
|
startup();
|
|
sock1 = create_udp_socket();
|
|
sock2 = create_udp_socket();
|
|
|
|
r = uv_udp_init(uv_default_loop(), &client);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_open(&client, sock1);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_udp_open(&client, sock2);
|
|
ASSERT(r == UV_EBUSY);
|
|
close_socket(sock2);
|
|
|
|
uv_close((uv_handle_t*) &client, NULL);
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|