Reverted for breaking Node.js in rather spectacular fashion.
The bug is arguably on the Node.js side. It looks like Node.js starts
reading before the socket is actually connected to something.
Until that is fixed downstream, let's revert the change.
This reverts commit fd049399aa.
Fixes: https://github.com/libuv/libuv/issues/1716
Fixes: https://github.com/nodejs/node/issues/18225
PR-URL: https://github.com/libuv/libuv/pull/1717
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
217 lines
5.3 KiB
C
217 lines
5.3 KiB
C
/* Copyright Joyent, Inc. and other Node contributors. All rights reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to
|
|
* deal in the Software without restriction, including without limitation the
|
|
* rights to use, copy, modify, merge, publish, distribute, sublicense, and/or
|
|
* sell copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include "uv.h"
|
|
#include "task.h"
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
|
|
|
|
static int close_cb_called = 0;
|
|
|
|
|
|
static void close_cb(uv_handle_t* handle) {
|
|
ASSERT(handle != NULL);
|
|
close_cb_called++;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_bind_error_addrinuse) {
|
|
struct sockaddr_in addr;
|
|
uv_tcp_t server1, server2;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("0.0.0.0", TEST_PORT, &addr));
|
|
r = uv_tcp_init(uv_default_loop(), &server1);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server1, (const struct sockaddr*) &addr, 0);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server2);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server2, (const struct sockaddr*) &addr, 0);
|
|
ASSERT(r == 0);
|
|
|
|
r = uv_listen((uv_stream_t*)&server1, 128, NULL);
|
|
ASSERT(r == 0);
|
|
r = uv_listen((uv_stream_t*)&server2, 128, NULL);
|
|
ASSERT(r == UV_EADDRINUSE);
|
|
|
|
uv_close((uv_handle_t*)&server1, close_cb);
|
|
uv_close((uv_handle_t*)&server2, close_cb);
|
|
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
ASSERT(close_cb_called == 2);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_bind_error_addrnotavail_1) {
|
|
struct sockaddr_in addr;
|
|
uv_tcp_t server;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("127.255.255.255", TEST_PORT, &addr));
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
|
|
/* It seems that Linux is broken here - bind succeeds. */
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) &addr, 0);
|
|
ASSERT(r == 0 || r == UV_EADDRNOTAVAIL);
|
|
|
|
uv_close((uv_handle_t*)&server, close_cb);
|
|
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
ASSERT(close_cb_called == 1);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_bind_error_addrnotavail_2) {
|
|
struct sockaddr_in addr;
|
|
uv_tcp_t server;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("4.4.4.4", TEST_PORT, &addr));
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) &addr, 0);
|
|
ASSERT(r == UV_EADDRNOTAVAIL);
|
|
|
|
uv_close((uv_handle_t*)&server, close_cb);
|
|
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
ASSERT(close_cb_called == 1);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_bind_error_fault) {
|
|
char garbage[] =
|
|
"blah blah blah blah blah blah blah blah blah blah blah blah";
|
|
struct sockaddr_in* garbage_addr;
|
|
uv_tcp_t server;
|
|
int r;
|
|
|
|
garbage_addr = (struct sockaddr_in*) &garbage;
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) garbage_addr, 0);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
uv_close((uv_handle_t*)&server, close_cb);
|
|
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
ASSERT(close_cb_called == 1);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
/* Notes: On Linux uv_bind(server, NULL) will segfault the program. */
|
|
|
|
TEST_IMPL(tcp_bind_error_inval) {
|
|
struct sockaddr_in addr1;
|
|
struct sockaddr_in addr2;
|
|
uv_tcp_t server;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("0.0.0.0", TEST_PORT, &addr1));
|
|
ASSERT(0 == uv_ip4_addr("0.0.0.0", TEST_PORT_2, &addr2));
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) &addr1, 0);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) &addr2, 0);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
uv_close((uv_handle_t*)&server, close_cb);
|
|
|
|
uv_run(uv_default_loop(), UV_RUN_DEFAULT);
|
|
|
|
ASSERT(close_cb_called == 1);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_bind_localhost_ok) {
|
|
struct sockaddr_in addr;
|
|
uv_tcp_t server;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("127.0.0.1", TEST_PORT, &addr));
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) &addr, 0);
|
|
ASSERT(r == 0);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_bind_invalid_flags) {
|
|
struct sockaddr_in addr;
|
|
uv_tcp_t server;
|
|
int r;
|
|
|
|
ASSERT(0 == uv_ip4_addr("127.0.0.1", TEST_PORT, &addr));
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
r = uv_tcp_bind(&server, (const struct sockaddr*) &addr, UV_TCP_IPV6ONLY);
|
|
ASSERT(r == UV_EINVAL);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|
|
|
|
|
|
TEST_IMPL(tcp_listen_without_bind) {
|
|
int r;
|
|
uv_tcp_t server;
|
|
|
|
r = uv_tcp_init(uv_default_loop(), &server);
|
|
ASSERT(r == 0);
|
|
r = uv_listen((uv_stream_t*)&server, 128, NULL);
|
|
ASSERT(r == 0);
|
|
|
|
MAKE_VALGRIND_HAPPY();
|
|
return 0;
|
|
}
|