luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: skip fs_event_close_in_callback on AIX

Browse Source 
The file descriptor that you receive from ahafs has to be part of the
pollset_poll set of interest in order to receive events. This does not
happen until we are in the event loop causing the test to hang and
therefore timeout.

PR-URL: https://github.com/libuv/libuv/pull/838
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit is contained in:
Imran Iqbal 2016-04-19 18:25:54 -04:00 committed by Ben Noordhuis
parent b9324acb75
commit faea76d81d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/test-fs-event.c
View File

@ -698,18 +698,19 @@ TEST_IMPL(fs_event_close_with_pending_event) {
return 0; return 0;
} }
#if defined(HAVE_KQUEUE) #if defined(HAVE_KQUEUE) || defined(_AIX)
/* kqueue doesn't register fs events if you don't have an active watcher. /* kqueue doesn't register fs events if you don't have an active watcher.
* The file descriptor needs to be part of the kqueue set of interest and * The file descriptor needs to be part of the kqueue set of interest and
* that's not the case until we actually enter the event loop. * that's not the case until we actually enter the event loop.
* This is also observed on AIX with ahafs.
*/ */
TEST_IMPL(fs_event_close_in_callback) { TEST_IMPL(fs_event_close_in_callback) {
fprintf(stderr, "Skipping test, doesn't work with kqueue.\n"); fprintf(stderr, "Skipping test, doesn't work with kqueue and AIX.\n");
return 0; return 0;
} }
#else /* !HAVE_KQUEUE */ #else /* !HAVE_KQUEUE || !_AIX */
static void fs_event_cb_close(uv_fs_event_t* handle, const char* filename, static void fs_event_cb_close(uv_fs_event_t* handle, const char* filename,
int events, int status) { int events, int status) {
@ -766,7 +767,7 @@ TEST_IMPL(fs_event_close_in_callback) {
return 0; return 0;
} }
#endif /* HAVE_KQUEUE */ #endif /* HAVE_KQUEUE || _AIX */
TEST_IMPL(fs_event_start_and_close) { TEST_IMPL(fs_event_start_and_close) {
uv_loop_t* loop; uv_loop_t* loop;