From f9c35197e64202099b691d53df7ea7db480b390c Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 14 Oct 2019 15:14:30 +0200 Subject: [PATCH] build: move -Wno-long-long check to configure time MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit xlc reportedly doesn't support the `-Wno-long-long` flag. Detect that at configure time instead of trying to fix it up at build time. This enables the flag for both the library and the test suite instead of just the test suite but that seems fine to me. PR-URL: https://github.com/libuv/libuv/pull/2512 Reviewed-By: Colin Ihrig Reviewed-By: Saúl Ibarra Corretgé Reviewed-By: Richard Lau --- Makefile.am | 4 ---- configure.ac | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/Makefile.am b/Makefile.am index ab7b97b5..ce4ca274 100644 --- a/Makefile.am +++ b/Makefile.am @@ -140,11 +140,7 @@ EXTRA_DIST = test/fixtures/empty_file \ TESTS = test/run-tests check_PROGRAMS = test/run-tests -if OS390 test_run_tests_CFLAGS = -else -test_run_tests_CFLAGS = -Wno-long-long -endif if SUNOS # Can't be turned into a CC_CHECK_CFLAGS in configure.ac, it makes compilers diff --git a/configure.ac b/configure.ac index cfc49719..db82c424 100644 --- a/configure.ac +++ b/configure.ac @@ -32,6 +32,7 @@ CC_CHECK_CFLAGS_APPEND([-g]) CC_CHECK_CFLAGS_APPEND([-std=gnu89]) CC_CHECK_CFLAGS_APPEND([-Wall]) CC_CHECK_CFLAGS_APPEND([-Wextra]) +CC_CHECK_CFLAGS_APPEND([-Wno-long-long]) CC_CHECK_CFLAGS_APPEND([-Wno-unused-parameter]) CC_CHECK_CFLAGS_APPEND([-Wstrict-prototypes]) # AM_PROG_AR is not available in automake v0.11 but it's essential in v0.12.