luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

win,pipe: ipc code does not support async read (#4555)

Browse Source 
The implementation of IPC pipe in libuv on Windows does not properly support
async reading. This means we cannot set the more parameter without likely
causing hangs. Sorry this is yet another followup to #4511.

Fixes #4548
This commit is contained in:
Jameson Nash 2024-10-03 16:12:22 -04:00 committed by GitHub
parent 88b874e63c
commit f55efb2f38
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/win/pipe.c
View File

@ -2094,17 +2094,13 @@ static int uv__pipe_read_ipc(uv_loop_t* loop, uv_pipe_t* handle) {
/* Store the pending socket info. */
uv__pipe_queue_ipc_xfer_info(handle, xfer_type, &xfer_info);
}
more = 1;
}
/* Return whether the caller should immediately try another read call to get
* more data. */
if (more && *data_remaining == 0) {
/* TODO: use PeekNamedPipe to see if it is really worth trying to do
* another ReadFile call. */
}
* more data. Calling uv__pipe_read_exactly will hang if there isn't data
* available, so we cannot do this unless we are guaranteed not to reach that.
*/
more = *data_remaining > 0;
return more;
invalid: