luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

core: change uv_get_password uid/gid to unsigned (#3476)

Browse Source 
Added in https://github.com/libuv/libuv/pull/742, these values are
typically defined as unsigned (since Linux 2.4). Only -1 is special,
representing an invalid id (e.g. see setreuid).
This commit is contained in:
Jameson Nash 2022-02-22 10:59:06 -05:00 committed by GitHub
parent c2a345fa67
commit f3e0bffcb1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/uv.h
View File

@ -1133,8 +1133,8 @@ struct uv_interface_address_s {
struct uv_passwd_s { struct uv_passwd_s {
char* username; char* username;
long uid; unsigned long uid;
long gid; unsigned long gid;
char* shell; char* shell;
char* homedir; char* homedir;
}; };

16
test/test-get-passwd.c
View File

@ -22,6 +22,10 @@
#include "uv.h" #include "uv.h"
#include "task.h" #include "task.h"
#include <string.h> #include <string.h>
#ifndef _WIN32
#include <unistd.h>
#include <sys/types.h>
#endif
TEST_IMPL(get_passwd) { TEST_IMPL(get_passwd) {
/* TODO(gengjiawen): Fix test on QEMU. */ /* TODO(gengjiawen): Fix test on QEMU. */
@ -64,11 +68,15 @@ TEST_IMPL(get_passwd) {
#endif #endif
#ifdef _WIN32 #ifdef _WIN32
ASSERT(pwd.uid == -1); ASSERT_EQ(pwd.uid, (unsigned)-1);
ASSERT(pwd.gid == -1); ASSERT_EQ(pwd.gid, (unsigned)-1);
#else #else
ASSERT(pwd.uid >= 0); ASSERT_NE(pwd.uid, (unsigned)-1);
ASSERT(pwd.gid >= 0); ASSERT_NE(pwd.gid, (unsigned)-1);
ASSERT_EQ(pwd.uid, geteuid());
if (pwd.uid != 0 && pwd.gid != getgid())
/* This will be likely true, as only root could have changed it. */
ASSERT_EQ(pwd.gid, getegid());
#endif #endif
/* Test uv_os_free_passwd() */ /* Test uv_os_free_passwd() */