luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

build: remove -pedantic from compiler flags

Browse Source 
This flag emits warnings with some versions of gcc that we don't care
about (libuv targets POSIX conformance, not strict ISO C conformance)
and it's arguably not that useful as libuv is compiled in -std=gnu89
mode.

Fixes: https://github.com/libuv/libuv/pull/2567
PR-URL: https://github.com/libuv/libuv/pull/2570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
This commit is contained in:
Ben Noordhuis 2019-12-16 15:19:08 +01:00
parent a0530ce77e
commit f0923d0251
2 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
configure.ac
View File

@ -24,9 +24,6 @@ AC_ENABLE_SHARED
AC_ENABLE_STATIC AC_ENABLE_STATIC
AC_PROG_CC AC_PROG_CC
AM_PROG_CC_C_O AM_PROG_CC_C_O
AS_IF([AS_CASE([$host_os],[openedition*], [false], [true])], [
CC_CHECK_CFLAGS_APPEND([-pedantic])
])
CC_FLAG_VISIBILITY #[-fvisibility=hidden] CC_FLAG_VISIBILITY #[-fvisibility=hidden]
CC_CHECK_CFLAGS_APPEND([-g]) CC_CHECK_CFLAGS_APPEND([-g])
CC_CHECK_CFLAGS_APPEND([-std=gnu89]) CC_CHECK_CFLAGS_APPEND([-std=gnu89])

3
uv.gyp
View File

@ -93,7 +93,7 @@
'-Wno-unused-parameter', '-Wno-unused-parameter',
'-Wstrict-prototypes', '-Wstrict-prototypes',
], ],
'OTHER_CFLAGS': [ '-g', '--std=gnu89', '-pedantic' ], 'OTHER_CFLAGS': [ '-g', '--std=gnu89' ],
}, },
'conditions': [ 'conditions': [
[ 'OS=="win"', { [ 'OS=="win"', {
@ -217,7 +217,6 @@
'-fvisibility=hidden', '-fvisibility=hidden',
'-g', '-g',
'--std=gnu89', '--std=gnu89',
'-pedantic',
'-Wall', '-Wall',
'-Wextra', '-Wextra',
'-Wno-unused-parameter', '-Wno-unused-parameter',