luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test,win: enable tcp_connect_error_after_write

Browse Source 
The test was added in 2012 but never enabled on Windows. Let's see how
it fares anno 2024.
This commit is contained in:
Ben Noordhuis 2024-01-15 09:42:11 +01:00 committed by Jameson Nash
parent 535efdf319
commit eeae108d46
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/test-tcp-connect-error-after-write.c
View File

@ -55,11 +55,6 @@ static void write_cb(uv_write_t* req, int status) {
* Related issue: https://github.com/joyent/libuv/issues/443 * Related issue: https://github.com/joyent/libuv/issues/443
*/ */
TEST_IMPL(tcp_connect_error_after_write) { TEST_IMPL(tcp_connect_error_after_write) {
#ifdef _WIN32
RETURN_SKIP("This test is disabled on Windows for now. "
"See https://github.com/joyent/libuv/issues/444\n");
#else
uv_connect_t connect_req; uv_connect_t connect_req;
struct sockaddr_in addr; struct sockaddr_in addr;
uv_write_t write_req; uv_write_t write_req;
@ -74,7 +69,11 @@ TEST_IMPL(tcp_connect_error_after_write) {
ASSERT_OK(r); ASSERT_OK(r);
r = uv_write(&write_req, (uv_stream_t*)&conn, &buf, 1, write_cb); r = uv_write(&write_req, (uv_stream_t*)&conn, &buf, 1, write_cb);
#ifdef _WIN32
ASSERT_EQ(r, UV_EPIPE);
#else
ASSERT_EQ(r, UV_EBADF); ASSERT_EQ(r, UV_EBADF);
#endif
r = uv_tcp_connect(&connect_req, r = uv_tcp_connect(&connect_req,
&conn, &conn,
@ -94,5 +93,4 @@ TEST_IMPL(tcp_connect_error_after_write) {
MAKE_VALGRIND_HAPPY(uv_default_loop()); MAKE_VALGRIND_HAPPY(uv_default_loop());
return 0; return 0;
#endif
} }