From e49ebd696e58b9e6e4d2c365ccf0d724d755834c Mon Sep 17 00:00:00 2001 From: Rui Abreu Ferreira Date: Wed, 22 Apr 2015 16:27:00 +0100 Subject: [PATCH] build: set SONAME for shared library in uv.gyp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For autoconf the libuv shared library SONAME is libuv.so.1.0 but gyp builds in UNIX were missing the proper SONAME. gyp does not have an explicit setting for SONAME. Changing the output file extensions triggers the use of SONAME. The previous gyp configuration also also caused issue joyent/libuv#1382, that prevented building the tests against a shared library - the issue is now fixed for UNIX. PR-URL: https://github.com/libuv/libuv/pull/329 Reviewed-By: Saúl Ibarra Corretgé --- uv.gyp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/uv.gyp b/uv.gyp index b7eeff40..53de6aa0 100644 --- a/uv.gyp +++ b/uv.gyp @@ -167,11 +167,10 @@ 'cflags': [ '-fPIC' ], }], ['uv_library=="shared_library" and OS!="mac"', { - 'link_settings': { - # Must correspond with UV_VERSION_MAJOR and UV_VERSION_MINOR - # in include/uv-version.h - 'libraries': [ '-Wl,-soname,libuv.so.1.0' ], - }, + # This will cause gyp to set soname + # Must correspond with UV_VERSION_MAJOR + # in include/uv-version.h + 'product_extension': 'so.1', }], ], }],