From cb1acaa46fcaa9aa47c63c9f10852cc938ec9767 Mon Sep 17 00:00:00 2001 From: Ruslan Bekenev Date: Sat, 3 Mar 2018 18:52:53 +0300 Subject: [PATCH] win,tty: update several TODO comments uv_process_tty_accept_req() and uv_process_tty_connect_req() are marked with "TODO: remove me" comments. This commit updates the comments to give a better explanation of why they exist. PR-URL: https://github.com/libuv/libuv/pull/1335 Reviewed-By: Colin Ihrig --- src/win/internal.h | 10 ++++++++-- src/win/tty.c | 10 ++++++++-- 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/src/win/internal.h b/src/win/internal.h index 217fcdb5..cce4e204 100644 --- a/src/win/internal.h +++ b/src/win/internal.h @@ -221,10 +221,16 @@ void uv_process_tty_read_req(uv_loop_t* loop, uv_tty_t* handle, uv_req_t* req); void uv_process_tty_write_req(uv_loop_t* loop, uv_tty_t* handle, uv_write_t* req); -/* TODO: remove me */ +/* + * uv_process_tty_accept_req() is a stub to keep DELEGATE_STREAM_REQ working + * TODO: find a way to remove it + */ void uv_process_tty_accept_req(uv_loop_t* loop, uv_tty_t* handle, uv_req_t* raw_req); -/* TODO: remove me */ +/* + * uv_process_tty_connect_req() is a stub to keep DELEGATE_STREAM_REQ working + * TODO: find a way to remove it + */ void uv_process_tty_connect_req(uv_loop_t* loop, uv_tty_t* handle, uv_connect_t* req); diff --git a/src/win/tty.c b/src/win/tty.c index 05a11e88..ecf7bc9b 100644 --- a/src/win/tty.c +++ b/src/win/tty.c @@ -2235,14 +2235,20 @@ void uv_tty_endgame(uv_loop_t* loop, uv_tty_t* handle) { } -/* TODO: remove me */ +/* + * uv_process_tty_accept_req() is a stub to keep DELEGATE_STREAM_REQ working + * TODO: find a way to remove it + */ void uv_process_tty_accept_req(uv_loop_t* loop, uv_tty_t* handle, uv_req_t* raw_req) { abort(); } -/* TODO: remove me */ +/* + * uv_process_tty_connect_req() is a stub to keep DELEGATE_STREAM_REQ working + * TODO: find a way to remove it + */ void uv_process_tty_connect_req(uv_loop_t* loop, uv_tty_t* handle, uv_connect_t* req) { abort();