luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

darwin: reduce fsevents thread stack size

Browse Source 
The fsevents watcher thread only needs a minimal amount of stack space
in order to run. Restrict its stack size so there's more address space
left for the libuv user.
This commit is contained in:
Ben Noordhuis 2013-08-13 09:56:48 +02:00
parent 06c4fa67ed
commit c82e7033a5
1 changed files with 26 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/unix/fsevents.c
View File

@ -43,6 +43,8 @@ void uv__fsevents_loop_delete(uv_loop_t* loop) {
#include <assert.h>
#include <stdlib.h>
#include <pthread.h>
#include <CoreFoundation/CFRunLoop.h>
#include <CoreServices/CoreServices.h>
@ -64,7 +66,7 @@ struct uv__fsevents_event_s {
/* Forward declarations */
static void uv__cf_loop_cb(void* arg);
static void uv__cf_loop_runner(void* arg);
static void* uv__cf_loop_runner(void* arg);
static void uv__cf_loop_signal(uv_loop_t* loop,
cf_loop_signal_cb cb,
void* arg);
@ -224,6 +226,8 @@ static void uv__fsevents_schedule(void* arg) {
static int uv__fsevents_loop_init(uv_loop_t* loop) {
CFRunLoopSourceContext ctx;
pthread_attr_t attr_storage;
pthread_attr_t* attr;
int err;
if (loop->cf_loop != NULL)
@ -243,7 +247,24 @@ static int uv__fsevents_loop_init(uv_loop_t* loop) {
ctx.perform = uv__cf_loop_cb;
loop->cf_cb = CFRunLoopSourceCreate(NULL, 0, &ctx);
err = uv_thread_create(&loop->cf_thread, uv__cf_loop_runner, loop);
/* In the unlikely event that pthread_attr_init() fails, create the thread
* with the default stack size. We'll use a little more address space but
* that in itself is not a fatal error.
*/
attr = &attr_storage;
if (pthread_attr_init(attr))
attr = NULL;
if (attr != NULL)
if (pthread_attr_setstacksize(attr, 3 * PTHREAD_STACK_MIN))
abort();
/* uv_thread_t is an alias for pthread_t. */
err = -pthread_create(&loop->cf_thread, attr, uv__cf_loop_runner, loop);
if (attr != NULL)
pthread_attr_destroy(attr);
if (err)
goto fail_thread_create;
@ -283,7 +304,7 @@ void uv__fsevents_loop_delete(uv_loop_t* loop) {
}
static void uv__cf_loop_runner(void* arg) {
static void* uv__cf_loop_runner(void* arg) {
uv_loop_t* loop;
loop = arg;
@ -299,6 +320,8 @@ static void uv__cf_loop_runner(void* arg) {
CFRunLoopRemoveSource(loop->cf_loop,
loop->cf_cb,
kCFRunLoopDefaultMode);
return NULL;
}