From bb1a49e9f2607458453713e3b6be5a5c8b9f2ae9 Mon Sep 17 00:00:00 2001 From: Jamie Davis Date: Mon, 17 Sep 2018 10:15:04 -0400 Subject: [PATCH] test: increase upper bound in condvar_5 Problem: Upper bound on thread wakeup was set to 1.5 * (requested timeout). On MacOS wakeup delay factors of 1.75 have been reported. Solution: Increase the bound to 5 * (requested timeout). Refs: https://github.com/libuv/libuv/issues/1910 PR-URL: https://github.com/libuv/libuv/pull/1990 Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno --- test/test-condvar.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test-condvar.c b/test/test-condvar.c index ec60f164..50f3c047 100644 --- a/test/test-condvar.c +++ b/test/test-condvar.c @@ -259,7 +259,7 @@ TEST_IMPL(condvar_5) { * https://msdn.microsoft.com/en-us/library/ms687069(VS.85).aspx */ elapsed = after - before; ASSERT(0.75 * timeout <= elapsed); /* 1.0 too large for Windows. */ - ASSERT(elapsed <= 1.5 * timeout); /* 1.1 too small for OSX. */ + ASSERT(elapsed <= 5.0 * timeout); /* MacOS has reported failures up to 1.75. */ worker_config_destroy(&wc);