From ad1c828827043fd1048582cee60103a68c8d929a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Klitzing?= Date: Fri, 7 Jul 2017 22:41:12 +0200 Subject: [PATCH] unix: check for NULL in uv_os_unsetenv for parameter name MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes segfault of unit test on musl (AlpineLinux). Add a check for parameter like uv_os_setenv do. PR-URL: https://github.com/libuv/libuv/pull/1409 Reviewed-By: Colin Ihrig Reviewed-By: Santiago Gimeno Reviewed-By: Saúl Ibarra Corretgé Reviewed-By: Ben Noordhuis --- src/unix/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/unix/core.c b/src/unix/core.c index 4c744925..a0513451 100644 --- a/src/unix/core.c +++ b/src/unix/core.c @@ -1292,6 +1292,9 @@ int uv_os_setenv(const char* name, const char* value) { int uv_os_unsetenv(const char* name) { + if (name == NULL) + return -EINVAL; + if (unsetenv(name) != 0) return -errno;