luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stream: start thread after assignments

Browse Source 
Changed the order of the member assignments since the thread
may start before the parameters are assigned. This especially
happens when the osx scheduler is very busy.
This commit is contained in:
Oguz Bastemur 2014-01-31 12:02:37 +01:00 committed by Fedor Indutny
parent 79ffe2fb95
commit a6ff04d2c4
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/unix/stream.c
View File

@ -282,6 +282,7 @@ int uv__stream_try_select(uv_stream_t* stream, int* fd) {
int fds[2];
int ret;
int kq;
int old_fd;
kq = kqueue();
if (kq == -1) {
@ -333,16 +334,20 @@ int uv__stream_try_select(uv_stream_t* stream, int* fd) {
s->fake_fd = fds[0];
s->int_fd = fds[1];
if (uv_thread_create(&s->thread, uv__stream_osx_select, stream))
goto fatal4;
old_fd = *fd;
s->stream = stream;
stream->select = s;
*fd = s->fake_fd;
if (uv_thread_create(&s->thread, uv__stream_osx_select, stream))
goto fatal4;
return 0;
fatal4:
s->stream = NULL;
stream->select = NULL;
*fd = old_fd;
close(s->fake_fd);
close(s->int_fd);
s->fake_fd = -1;