From a478847f747b1af3fc0acfd657e5b49c66ffb3e7 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Tue, 22 May 2012 16:04:09 +0200 Subject: [PATCH] test: add callback order test Ensure that idle callbacks run before other callbacks. --- test/test-callback-order.c | 76 ++++++++++++++++++++++++++++++++++++++ test/test-list.h | 2 + uv.gyp | 1 + 3 files changed, 79 insertions(+) create mode 100644 test/test-callback-order.c diff --git a/test/test-callback-order.c b/test/test-callback-order.c new file mode 100644 index 00000000..a6c40cbd --- /dev/null +++ b/test/test-callback-order.c @@ -0,0 +1,76 @@ +/* Copyright Joyent, Inc. and other Node contributors. All rights reserved. + * + * Permission is hereby granted, free of charge, to any person obtaining a copy + * of this software and associated documentation files (the "Software"), to + * deal in the Software without restriction, including without limitation the + * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the Software is + * furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in + * all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE + * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +#include "uv.h" +#include "task.h" + +static int idle_cb_called; +static int timer_cb_called; + +static uv_idle_t idle_handle; +static uv_timer_t timer_handle; + + +/* idle_cb should run before timer_cb */ +static void idle_cb(uv_idle_t* handle, int status) { + ASSERT(idle_cb_called == 0); + ASSERT(timer_cb_called == 0); + uv_idle_stop(handle); + idle_cb_called++; +} + + +static void timer_cb(uv_timer_t* handle, int status) { + ASSERT(idle_cb_called == 1); + ASSERT(timer_cb_called == 0); + uv_timer_stop(handle); + timer_cb_called++; +} + + +static void next_tick(uv_idle_t* handle, int status) { + uv_loop_t* loop = handle->loop; + uv_idle_stop(handle); + uv_idle_init(loop, &idle_handle); + uv_idle_start(&idle_handle, idle_cb); + uv_timer_init(loop, &timer_handle); + uv_timer_start(&timer_handle, timer_cb, 0, 0); +} + + +TEST_IMPL(callback_order) { + uv_loop_t* loop; + uv_idle_t idle; + + loop = uv_default_loop(); + uv_idle_init(loop, &idle); + uv_idle_start(&idle, next_tick); + + ASSERT(idle_cb_called == 0); + ASSERT(timer_cb_called == 0); + + uv_run(loop); + + ASSERT(idle_cb_called == 1); + ASSERT(timer_cb_called == 1); + + return 0; +} diff --git a/test/test-list.h b/test/test-list.h index c8e222b8..86fbad4e 100644 --- a/test/test-list.h +++ b/test/test-list.h @@ -20,6 +20,7 @@ */ TEST_DECLARE (platform_output) +TEST_DECLARE (callback_order) TEST_DECLARE (tty) TEST_DECLARE (stdio_over_pipes) TEST_DECLARE (ipc_listen_before_write) @@ -181,6 +182,7 @@ HELPER_DECLARE (pipe_echo_server) TASK_LIST_START TEST_OUTPUT_ENTRY (platform_output) + TEST_ENTRY (callback_order) TEST_ENTRY (pipe_connect_bad_name) TEST_ENTRY (pipe_connect_to_file) diff --git a/uv.gyp b/uv.gyp index acef43a2..24da3e2d 100644 --- a/uv.gyp +++ b/uv.gyp @@ -301,6 +301,7 @@ 'test/test-async.c', 'test/test-error.c', 'test/test-callback-stack.c', + 'test/test-callback-order.c', 'test/test-connection-fail.c', 'test/test-cwd-and-chdir.c', 'test/test-delayed-accept.c',