luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: fix musl libc.a dlerror() test expectation (#3735)

Browse Source 
Dynamic loading with musl only works with libc.so because it is
is implemented in musl's dynamic linker, not in libc proper.

libc.a contains just a stub dlopen() that always fails with a "Dynamic
loading not supported" error message. Update the test to handle that.

Fix: https://github.com/libuv/libuv/issues/3706
This commit is contained in:
Ben Noordhuis 2022-09-07 17:21:24 +02:00 committed by GitHub
parent a855c74183
commit 9d898acc56
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/test-dlerror.c
View File

@ -43,7 +43,9 @@ TEST_IMPL(dlerror) {
msg = uv_dlerror(&lib);
ASSERT_NOT_NULL(msg);
#if !defined(__OpenBSD__) && !defined(__QNX__)
ASSERT_NOT_NULL(strstr(msg, path));
/* musl's libc.a does not support dlopen(), only libc.so does. */
if (NULL == strstr(msg, "Dynamic loading not supported"))
ASSERT_NOT_NULL(strstr(msg, path));
#endif
ASSERT_NULL(strstr(msg, dlerror_no_error));
@ -51,7 +53,9 @@ TEST_IMPL(dlerror) {
msg = uv_dlerror(&lib);
ASSERT_NOT_NULL(msg);
#if !defined(__OpenBSD__) && !defined(__QNX__)
ASSERT_NOT_NULL(strstr(msg, path));
/* musl's libc.a does not support dlopen(), only libc.so does. */
if (NULL == strstr(msg, "Dynamic loading not supported"))
ASSERT_NOT_NULL(strstr(msg, path));
#endif
ASSERT_NULL(strstr(msg, dlerror_no_error));