luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unix: change uv_dl*() error code

Browse Source 
Return UV_ENOENT instead of UV_EINVAL. UV_EINVAL was arbitrarily chosen and
turns out to be inconsistent with the Windows implementation.

Fixes #395.
This commit is contained in:
Ben Noordhuis 2012-04-29 21:35:31 +02:00
parent acd0afb296
commit 93d16e6a84
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/unix/dl.c
View File

@ -31,13 +31,13 @@
* errors to the caller but there is only dlerror() and that returns a string -
* a string that may or may not be safe to keep a reference to...
*/
static const uv_err_t uv_inval_ = { UV_EINVAL, EINVAL };
static const uv_err_t uv_err_ = { UV_ENOENT, ENOENT };
uv_err_t uv_dlopen(const char* filename, uv_lib_t* library) {
void* handle = dlopen(filename, RTLD_LAZY);
if (handle == NULL) {
return uv_inval_;
return uv_err_;
}
*library = handle;
@ -47,7 +47,7 @@ uv_err_t uv_dlopen(const char* filename, uv_lib_t* library) {
uv_err_t uv_dlclose(uv_lib_t library) {
if (dlclose(library) != 0) {
return uv_inval_;
return uv_err_;
}
return uv_ok_;
@ -63,7 +63,7 @@ uv_err_t uv_dlsym(uv_lib_t library, const char* name, void** ptr) {
address = dlsym(library, name);
if (dlerror()) {
return uv_inval_;
return uv_err_;
}
*ptr = (void*) address;