windows: fix PYTHON environment variable usage
- (README.md) The PYTHON environment variable should point to python.exe not the python directory. - (vcvars.bat) The PYTHON environment variable should be quoted on expansion in case there's spaces in the path.
This commit is contained in:
parent
2d45af8b25
commit
90e4afd4fa
@ -66,10 +66,9 @@ To build with autotools:
|
||||
|
||||
### Windows
|
||||
|
||||
First, Python 2.6 or 2.7 must be installed as it is required by [GYP][].
|
||||
|
||||
Also, the directory for the preferred Python executable must be specified
|
||||
by the `PYTHON` or `Path` environment variables.
|
||||
First, [Python][] 2.6 or 2.7 must be installed as it is required by [GYP][].
|
||||
If python is not in your path set the environment variable `PYTHON` to its
|
||||
location. For example: `set PYTHON=C:\Python27\python.exe`
|
||||
|
||||
To build with Visual Studio, launch a git shell (e.g. Cmd or PowerShell)
|
||||
and run vcbuild.bat which will checkout the GYP code into build/gyp and
|
||||
@ -139,5 +138,6 @@ See the [guidelines for contributing][].
|
||||
|
||||
[node.js]: http://nodejs.org/
|
||||
[GYP]: http://code.google.com/p/gyp/
|
||||
[Python]: https://www.python.org/downloads/
|
||||
[Visual Studio Express 2010]: http://www.microsoft.com/visualstudio/eng/products/visual-studio-2010-express
|
||||
[guidelines for contributing]: https://github.com/joyent/libuv/blob/master/CONTRIBUTING.md
|
||||
|
||||
@ -101,8 +101,8 @@ echo manually install gyp into %~dp0build\gyp.
|
||||
exit /b 1
|
||||
|
||||
:have_gyp
|
||||
if not defined PYTHON set PYTHON="python"
|
||||
%PYTHON% gyp_uv.py -Dtarget_arch=%target_arch% -Duv_library=%library%
|
||||
if not defined PYTHON set PYTHON=python
|
||||
"%PYTHON%" gyp_uv.py -Dtarget_arch=%target_arch% -Duv_library=%library%
|
||||
if errorlevel 1 goto create-msvs-files-failed
|
||||
if not exist uv.sln goto create-msvs-files-failed
|
||||
echo Project files generated.
|
||||
|
||||
Loading…
Reference in New Issue
Block a user