luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unix, windows: pass const handle ptr to uv_tcp_get*name

Browse Source 
uv_tcp_getsockname and uv_tcp_getpeername do not modify passed handle
pointer, so there is no need to keep this parameter non-const.
This commit is contained in:
Chernyshev Viacheslav 2014-04-17 16:01:43 +04:00 committed by Saúl Ibarra Corretgé
parent 4018f72615
commit 886e2bcd55
3 changed files with 14 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/uv.h
View File

@ -809,10 +809,12 @@ enum uv_tcp_flags {
UV_EXTERN int uv_tcp_bind(uv_tcp_t* handle,
const struct sockaddr* addr,
unsigned int flags);
UV_EXTERN int uv_tcp_getsockname(uv_tcp_t* handle, struct sockaddr* name,
int* namelen);
UV_EXTERN int uv_tcp_getpeername(uv_tcp_t* handle, struct sockaddr* name,
int* namelen);
UV_EXTERN int uv_tcp_getsockname(const uv_tcp_t* handle,
struct sockaddr* name,
int* namelen);
UV_EXTERN int uv_tcp_getpeername(const uv_tcp_t* handle,
struct sockaddr* name,
int* namelen);
/*
* Establish an IPv4 or IPv6 TCP connection. Provide an initialized TCP handle

4
src/unix/tcp.c
View File

@ -158,7 +158,7 @@ int uv_tcp_open(uv_tcp_t* handle, uv_os_sock_t sock) {
}
int uv_tcp_getsockname(uv_tcp_t* handle,
int uv_tcp_getsockname(const uv_tcp_t* handle,
struct sockaddr* name,
int* namelen) {
socklen_t socklen;
@ -180,7 +180,7 @@ int uv_tcp_getsockname(uv_tcp_t* handle,
}
int uv_tcp_getpeername(uv_tcp_t* handle,
int uv_tcp_getpeername(const uv_tcp_t* handle,
struct sockaddr* name,
int* namelen) {
socklen_t socklen;

10
src/win/tcp.c
View File

@ -747,8 +747,9 @@ static int uv_tcp_try_connect(uv_connect_t* req,
}
int uv_tcp_getsockname(uv_tcp_t* handle, struct sockaddr* name,
int* namelen) {
int uv_tcp_getsockname(const uv_tcp_t* handle,
struct sockaddr* name,
int* namelen) {
int result;
if (!(handle->flags & UV_HANDLE_BOUND)) {
@ -768,8 +769,9 @@ int uv_tcp_getsockname(uv_tcp_t* handle, struct sockaddr* name,
}
int uv_tcp_getpeername(uv_tcp_t* handle, struct sockaddr* name,
int* namelen) {
int uv_tcp_getpeername(const uv_tcp_t* handle,
struct sockaddr* name,
int* namelen) {
int result;
if (!(handle->flags & UV_HANDLE_BOUND)) {