From 77e6bd4874de73c772f5a3fa50b4727ed4ffaa13 Mon Sep 17 00:00:00 2001 From: AJ Heller Date: Tue, 2 Nov 2021 10:58:25 -0700 Subject: [PATCH] build: fix win build with cmake versions before v3.14 (#3343) Before v3.14, cmake throws the following error: ``` CMake Error at third_party/libuv/CMakeLists.txt:663 (install): install Library TARGETS given no DESTINATION! ``` I confirmed on Windows 7 and Windows Server 2016, with about a dozen cmake versions between 3.7 and 3.22. I also confirmed that the DESTINATION `${CMAKE_INSTALL_LIBDIR}` is populated with a valid path. PR-URL: https://github.com/libuv/libuv/pull/3343 --- CMakeLists.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 16a8cc5d..337b09c2 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -660,7 +660,9 @@ install(DIRECTORY include/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}) install(FILES LICENSE DESTINATION ${CMAKE_INSTALL_DOCDIR}) install(FILES ${PROJECT_BINARY_DIR}/libuv.pc ${PROJECT_BINARY_DIR}/libuv-static.pc DESTINATION ${CMAKE_INSTALL_LIBDIR}/pkgconfig) -install(TARGETS uv EXPORT libuvConfig LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}) +install(TARGETS uv EXPORT libuvConfig + RUNTIME DESTINATION ${CMAKE_INSTALL_LIBDIR} + LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR}) install(TARGETS uv_a ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR}) install(EXPORT libuvConfig DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/libuv)