pipe: remove useless assertion (#3302)

This assertion was added when req->write_buffer was a pointer. It was
then checking that write_buffer itself was not NULL. Checking that .base
is not NULL is superfluous because WriteFile will return error 998
(ERROR_NO_ACCESS) if the input buffer is invalid. This assertion fires
on zero-length writes when base==NULL&&len==0.
This commit is contained in:
~locpyl-tidnyd 2021-10-16 13:17:38 +03:00 committed by GitHub
parent 22d6223928
commit 5b00797205
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1252,7 +1252,6 @@ static DWORD WINAPI uv_pipe_writefile_thread_proc(void* parameter) {
assert(req != NULL);
assert(req->type == UV_WRITE);
assert(handle->type == UV_NAMED_PIPE);
assert(req->write_buffer.base);
result = WriteFile(handle->handle,
req->write_buffer.base,