From 4f43a8673b1e1ae6a5a02c77ee83d2af003b45bb Mon Sep 17 00:00:00 2001 From: Ujjwal Sharma Date: Fri, 6 Jul 2018 10:05:23 +0530 Subject: [PATCH] fs: change position of uv_fs_lchown Change the position of UV_LS_LCHOWN, moving it to the end in order to go around a bug due to it's initial position. The original position of UV_LS_LCHOWN broke ABI compat, causing a binary using UV_FS_REALPATH or UV_FS_COPYFILE to break, as the values point to wrong function. Refs: https://github.com/yarnpkg/yarn/issues/6043 Fixes: https://github.com/libuv/libuv/issues/1908 PR-URL: https://github.com/libuv/libuv/pull/1913 Reviewed-By: Santiago Gimeno Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau --- docs/src/fs.rst | 4 ++-- include/uv.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/src/fs.rst b/docs/src/fs.rst index a390f140..f383e5b1 100644 --- a/docs/src/fs.rst +++ b/docs/src/fs.rst @@ -92,9 +92,9 @@ Data types UV_FS_READLINK, UV_FS_CHOWN, UV_FS_FCHOWN, - UV_FS_LCHOWN, UV_FS_REALPATH, - UV_FS_COPYFILE + UV_FS_COPYFILE, + UV_FS_LCHOWN } uv_fs_type; .. c:type:: uv_dirent_t diff --git a/include/uv.h b/include/uv.h index 7565769c..a8b30579 100644 --- a/include/uv.h +++ b/include/uv.h @@ -1144,9 +1144,9 @@ typedef enum { UV_FS_READLINK, UV_FS_CHOWN, UV_FS_FCHOWN, - UV_FS_LCHOWN, UV_FS_REALPATH, - UV_FS_COPYFILE + UV_FS_COPYFILE, + UV_FS_LCHOWN } uv_fs_type; /* uv_fs_t is a subclass of uv_req_t. */