luo980/libuv
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: disable signal test under ASan and MSan (#3961)

Browse Source 
The signal_multiple_loops test is flaky when run under AddressSanitizer
and MemorySanitizer. Sometimes thread creation fails, other times it
simply times out.

Fixes: https://github.com/libuv/libuv/issues/3956
This commit is contained in:
Ben Noordhuis 2023-04-19 07:40:18 +02:00 committed by GitHub
parent a7ff759ca1
commit 3ba75f1300
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/test-signal-multiple-loops.c
View File

@ -208,9 +208,13 @@ TEST_IMPL(signal_multiple_loops) {
#endif #endif
/* TODO(gengjiawen): Fix test on QEMU. */ /* TODO(gengjiawen): Fix test on QEMU. */
#if defined(__QEMU__) #if defined(__QEMU__)
// See https://github.com/libuv/libuv/issues/2859 /* See https://github.com/libuv/libuv/issues/2859 */
RETURN_SKIP("QEMU's signal emulation code is notoriously tricky"); RETURN_SKIP("QEMU's signal emulation code is notoriously tricky");
#endif #endif
#if defined(__ASAN__) || defined(__MSAN__)
/* See https://github.com/libuv/libuv/issues/3956 */
RETURN_SKIP("Test is too slow to run under ASan or MSan");
#endif
#if defined(__TSAN__) #if defined(__TSAN__)
/* ThreadSanitizer complains - likely legitimately - about data races /* ThreadSanitizer complains - likely legitimately - about data races
* in uv__signal_compare() in src/unix/signal.c but that's pre-existing. * in uv__signal_compare() in src/unix/signal.c but that's pre-existing.