From 2414d7e728aac1e9e079c2a90adb6f4b143e58ee Mon Sep 17 00:00:00 2001
From: Ryan Dahl <ry@tinyclouds.org>
Date: Fri, 15 Apr 2011 10:26:51 -0700
Subject: [PATCH] Fix close_cb_stack

---
 Makefile   |  2 +-
 TODO       |  6 ++++-
 oio-unix.c | 72 +++++++++++++++++++++++++++++++++++++++++++++++-------
 oio-unix.h |  6 ++---
 4 files changed, 71 insertions(+), 15 deletions(-)

diff --git a/Makefile b/Makefile
index 1ac988fb..e2c3e3a0 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,4 @@
-all: oio.a
+all: oio.a test/test-runner
 
 TESTS=test/echo-server.c \
 			test/test-pass-always.c \
diff --git a/TODO b/TODO
index 5b482307..862650b2 100644
--- a/TODO
+++ b/TODO
@@ -1,2 +1,6 @@
-"test-runner ping_pong" should run just the ping pong test with the echo
+- "test-runner ping_pong" should run just the ping pong test with the echo
 server process.
+
+- FATAL should take a string
+
+- ASSERT and FATAL should require semicolons.
diff --git a/oio-unix.c b/oio-unix.c
index d2b00548..1c4326b5 100644
--- a/oio-unix.c
+++ b/oio-unix.c
@@ -28,7 +28,29 @@ size_t strnlen (register const char* s, size_t maxlen) {
 void oio_tcp_io(EV_P_ ev_io* watcher, int revents);
 void oio_tcp_connect(oio_handle* handle, oio_req* req);
 int oio_tcp_open(oio_handle*, int fd);
-int oio_close_error(oio_handle* handle, oio_err err);
+void oio_finish_close(oio_handle* handle);
+
+
+/* flags */
+enum {
+  OIO_CLOSING = 0x00000001,
+  OIO_CLOSED  = 0x00000002
+};
+
+
+void oio_flag_set(oio_handle* handle, int flag) {
+  handle->flags |= flag;
+}
+
+
+void oio_flag_unset(oio_handle* handle, int flag) {
+  handle->flags = handle->flags & ~flag;
+}
+
+
+int oio_flag_is_set(oio_handle* handle, int flag) {
+  return handle->flags & flag;
+}
 
 
 static oio_err oio_err_new(oio_handle* handle, int e) {
@@ -36,6 +58,7 @@ static oio_err oio_err_new(oio_handle* handle, int e) {
   return e;
 }
 
+
 oio_err oio_err_last(oio_handle *handle) {
   return handle->err;
 }
@@ -53,7 +76,16 @@ struct sockaddr_in oio_ip4_addr(char *ip, int port) {
 
 
 int oio_close(oio_handle* handle) {
-  return oio_close_error(handle, 0);
+  oio_flag_set(handle, OIO_CLOSING);
+
+  if (!ev_is_active(&handle->read_watcher)) {
+    ev_io_init(&handle->read_watcher, oio_tcp_io, handle->fd, EV_READ);
+    ev_io_start(EV_DEFAULT_ &handle->read_watcher);
+  }
+
+  ev_feed_fd_event(EV_DEFAULT_ handle->fd, EV_READ | EV_WRITE);
+
+  return 0;
 }
 
 
@@ -73,6 +105,7 @@ int oio_tcp_handle_init(oio_handle *handle, oio_close_cb close_cb,
   handle->close_cb = close_cb;
   handle->data = data;
   handle->accepted_fd = -1;
+  handle->flags = 0;
 
   ngx_queue_init(&handle->read_reqs);
 
@@ -149,6 +182,11 @@ void oio_server_io(EV_P_ ev_io* watcher, int revents) {
 
   assert(revents == EV_READ);
 
+  if (oio_flag_is_set(handle, OIO_CLOSING)) {
+    oio_finish_close(handle);
+    return;
+  }
+
   if (handle->accepted_fd >= 0) {
     ev_io_stop(EV_DEFAULT_ &handle->read_watcher);
     return;
@@ -169,7 +207,8 @@ void oio_server_io(EV_P_ ev_io* watcher, int revents) {
         /* TODO special trick. unlock reserved socket, accept, close. */
         return;
       } else {
-        oio_close_error(handle, oio_err_new(handle, errno));
+        handle->err = oio_err_new(handle, errno);
+        oio_close(handle);
       }
 
     } else {
@@ -225,16 +264,24 @@ int oio_listen(oio_handle* handle, int backlog, oio_accept_cb cb) {
 }
 
 
-int oio_close_error(oio_handle* handle, oio_err err) {
+void oio_finish_close(oio_handle* handle) {
+  assert(!oio_flag_is_set(handle, OIO_CLOSED));
+  oio_flag_set(handle, OIO_CLOSED);
+
   ev_io_stop(EV_DEFAULT_ &handle->read_watcher);
+  ev_io_stop(EV_DEFAULT_ &handle->write_watcher);
   close(handle->fd);
+
   handle->fd = -1;
 
-  if (handle->close_cb) {
-    handle->close_cb(handle, err);
+  if (handle->accepted_fd >= 0) {
+    close(handle->accepted_fd);
+    handle->accepted_fd = -1;
   }
 
-  return err;
+  if (handle->close_cb) {
+    handle->close_cb(handle, 0);
+  }
 }
 
 
@@ -290,7 +337,8 @@ void oio__read(oio_handle* handle) {
       if (cb) {
         cb(req, 0);
       }
-      oio_close_error(handle, errno);
+      handle->err = errno;
+      oio_close(handle);
     }
   } else {
     /* Successful read */
@@ -318,6 +366,11 @@ void oio_tcp_io(EV_P_ ev_io* watcher, int revents) {
 
   assert(handle->fd >= 0);
 
+  if (oio_flag_is_set(handle, OIO_CLOSING)) {
+    oio_finish_close(handle);
+    return;
+  }
+
   if (handle->connect_req) {
     oio_tcp_connect(handle, handle->connect_req);
   } else {
@@ -368,7 +421,8 @@ void oio_tcp_connect(oio_handle* handle, oio_req* req) {
       req->connect_cb(req, err);
     }
 
-    oio_close_error(handle, err);
+    handle->err = err;
+    oio_close(handle);
   }
 }
 
diff --git a/oio-unix.h b/oio-unix.h
index f84dccd0..10af900a 100644
--- a/oio-unix.h
+++ b/oio-unix.h
@@ -11,9 +11,7 @@
 #include <netinet/tcp.h>
 
 
-/**
- * Note can be cast to io_vec.
- */
+/* Note: May be cast to struct iovec. See writev(2). */
 typedef struct {
   char* base;
   size_t len;
@@ -21,7 +19,6 @@ typedef struct {
 
 
 #define oio_req_private_fields \
-  int local; \
   oio_connect_cb connect_cb; \
   ngx_queue_t read_reqs; \
   oio_buf* read_bufs; \
@@ -30,6 +27,7 @@ typedef struct {
 
 #define oio_handle_private_fields \
   int fd; \
+  int flags; \
   oio_err err; \
   oio_read_cb read_cb; \
   oio_accept_cb accept_cb; \