luo980/json
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enable modernize-use-integer-sign-comparison check (#4581)

Browse Source 
Signed-off-by: Niels Lohmann <mail@nlohmann.me>
This commit is contained in:
Niels Lohmann 2025-01-02 13:24:05 +01:00 committed by GitHub
parent 4f64d8d0b4
commit f038ac4c9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.clang-tidy
View File

@ -53,7 +53,6 @@ Checks: '*,
-modernize-type-traits, -modernize-type-traits,
-modernize-use-constraints, -modernize-use-constraints,
-modernize-use-designated-initializers, -modernize-use-designated-initializers,
-modernize-use-integer-sign-comparison,
-modernize-use-nodiscard, -modernize-use-nodiscard,
-modernize-use-ranges, -modernize-use-ranges,
-modernize-use-std-numbers, -modernize-use-std-numbers,

2
tests/src/unit-alt-string.cpp
View File

@ -28,7 +28,7 @@ class alt_string
public: public:
using value_type = std::string::value_type; using value_type = std::string::value_type;
static constexpr auto npos = static_cast<std::size_t>(-1); static constexpr auto npos = (std::numeric_limits<std::size_t>::max)();
alt_string(const char* str): str_impl(str) {} alt_string(const char* str): str_impl(str) {}
alt_string(const char* str, std::size_t count): str_impl(str, count) {} alt_string(const char* str, std::size_t count): str_impl(str, count) {}

4
tests/src/unit-class_parser.cpp
View File

@ -75,7 +75,7 @@ class SaxEventLogger
bool start_object(std::size_t elements) bool start_object(std::size_t elements)
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_object()"); events.emplace_back("start_object()");
} }
@ -100,7 +100,7 @@ class SaxEventLogger
bool start_array(std::size_t elements) bool start_array(std::size_t elements)
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_array()"); events.emplace_back("start_array()");
} }

4
tests/src/unit-class_parser_diagnostic_positions.cpp
View File

@ -80,7 +80,7 @@ class SaxEventLogger
bool start_object(std::size_t elements) bool start_object(std::size_t elements)
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_object()"); events.emplace_back("start_object()");
} }
@ -105,7 +105,7 @@ class SaxEventLogger
bool start_array(std::size_t elements) bool start_array(std::size_t elements)
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_array()"); events.emplace_back("start_array()");
} }

8
tests/src/unit-deserialization.cpp
View File

@ -76,7 +76,7 @@ struct SaxEventLogger : public nlohmann::json_sax<json>
bool start_object(std::size_t elements) override bool start_object(std::size_t elements) override
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_object()"); events.emplace_back("start_object()");
} }
@ -101,7 +101,7 @@ struct SaxEventLogger : public nlohmann::json_sax<json>
bool start_array(std::size_t elements) override bool start_array(std::size_t elements) override
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_array()"); events.emplace_back("start_array()");
} }
@ -131,7 +131,7 @@ struct SaxEventLoggerExitAfterStartObject : public SaxEventLogger
{ {
bool start_object(std::size_t elements) override bool start_object(std::size_t elements) override
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_object()"); events.emplace_back("start_object()");
} }
@ -156,7 +156,7 @@ struct SaxEventLoggerExitAfterStartArray : public SaxEventLogger
{ {
bool start_array(std::size_t elements) override bool start_array(std::size_t elements) override
{ {
if (elements == static_cast<std::size_t>(-1)) if (elements == (std::numeric_limits<std::size_t>::max)())
{ {
events.emplace_back("start_array()"); events.emplace_back("start_array()");
} }