luo980/json-schema-validator
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace dynamic_cast with member functions (#210)

Browse Source
This commit is contained in:
Chris Wright 2022-07-05 17:47:23 +01:00 committed by Patrick Boettcher
parent 5ec1961439
commit e1e48ddbe0
1 changed files with 39 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
src/json-validator.cpp
View File

@ -40,6 +40,16 @@ protected:
root_schema *root_; root_schema *root_;
json default_value_ = nullptr; json default_value_ = nullptr;
protected:
virtual std::shared_ptr<schema> make_for_default_(
std::shared_ptr<::schema> & /* sch */,
root_schema * /* root */,
std::vector<nlohmann::json_uri> & /* uris */,
nlohmann::json & /* default_value */) const
{
return nullptr;
};
public: public:
virtual ~schema() = default; virtual ~schema() = default;
@ -92,6 +102,21 @@ class schema_ref : public schema
return default_value_; return default_value_;
} }
protected:
virtual std::shared_ptr<schema> make_for_default_(
std::shared_ptr<::schema> &sch,
root_schema *root,
std::vector<nlohmann::json_uri> &uris,
nlohmann::json &default_value) const override
{
// create a new reference schema using the original reference (which will be resolved later)
// to store this overloaded default value #209
auto result = std::make_shared<schema_ref>(uris[0].to_string(), root);
result->set_target(sch, true);
result->set_default_value(default_value);
return result;
};
public: public:
schema_ref(const std::string &id, root_schema *root) schema_ref(const std::string &id, root_schema *root)
: schema(root), id_(id) {} : schema(root), id_(id) {}
@ -509,6 +534,18 @@ class type_schema : public schema
} }
} }
protected:
virtual std::shared_ptr<schema> make_for_default_(
std::shared_ptr<::schema> & /* sch */,
root_schema * /* root */,
std::vector<nlohmann::json_uri> & /* uris */,
nlohmann::json &default_value) const override
{
auto result = std::make_shared<type_schema>(*this);
result->set_default_value(default_value);
return result;
};
public: public:
type_schema(json &sch, type_schema(json &sch,
root_schema *root, root_schema *root,
@ -1289,16 +1326,8 @@ std::shared_ptr<schema> schema::make(json &schema,
attr = schema.find("default"); attr = schema.find("default");
if (attr != schema.end()) { if (attr != schema.end()) {
// copy the referenced schema depending on the underlying type and modify the default value // copy the referenced schema depending on the underlying type and modify the default value
if (dynamic_cast<schema_ref *>(sch.get())) { if (auto new_sch = sch->make_for_default_(sch, root, uris, attr.value())) {
// create a new reference schema use the original reference (which will be resolved later) sch = new_sch;
// to store this overloaed default value #209
auto overloaded_ref_sch = std::make_shared<schema_ref>(uris[0].to_string(), root);
overloaded_ref_sch->set_target(sch, true);
overloaded_ref_sch->set_default_value(attr.value());
sch = overloaded_ref_sch;
} else if (auto *type_sch = dynamic_cast<type_schema *>(sch.get())) {
sch = std::make_shared<type_schema>(*type_sch);
sch->set_default_value(attr.value());
} }
schema.erase(attr); schema.erase(attr);
} }