luo980/hiredis
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve SSL leak fix redis/hiredis#896

Browse Source 
Free SSL object when redisSSLConnect fails but avoid doing that for
callers of redisInitiateSSL who are supposed to manager their own SSL
object.

Signed-off-by: Hans Zandbelt <hans.zandbelt@zmartzone.eu>
This commit is contained in:
Hans Zandbelt 2021-04-11 18:49:38 +02:00
parent dfa33e60b0
commit 5f4382247a
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
ssl.c
View File

@ -351,7 +351,6 @@ static int redisSSLConnect(redisContext *c, SSL *ssl) {
} }
hi_free(rssl); hi_free(rssl);
SSL_free(ssl);
return REDIS_ERR; return REDIS_ERR;
} }
@ -393,7 +392,11 @@ int redisInitiateSSLWithContext(redisContext *c, redisSSLContext *redis_ssl_ctx)
} }
} }
return redisSSLConnect(c, ssl); if (redisSSLConnect(c, ssl) != REDIS_OK) {
goto error;
}
return REDIS_OK;
error: error:
if (ssl) if (ssl)