Test old logs are cleared when using max-num-log-files

CMakeLists.txt

@@ -729,6 +729,11 @@ if (BUILD_TESTING)
 
   target_link_libraries (cleanup_with_relative_prefix_unittest PRIVATE glog_test)
 
+  add_executable (cleanup_too_many_logs_unittest
+    src/cleanup_too_many_logs_unittest.cc)
+
+  target_link_libraries (cleanup_too_many_logs_unittest PRIVATE glog_test)
+
   set (CLEANUP_LOG_DIR ${glog_BINARY_DIR}/cleanup_tests)
 
   add_test (NAME cleanup_init COMMAND
@@ -755,6 +760,13 @@ if (BUILD_TESTING)
     -DTEST_SUBDIR=test_subdir/
     -P ${glog_SOURCE_DIR}/cmake/RunCleanerTest3.cmake
     WORKING_DIRECTORY ${glog_BINARY_DIR})
+  add_test (NAME cleanup_too_many_logs COMMAND
+    ${CMAKE_COMMAND}
+    -DLOGCLEANUP=$<TARGET_FILE:cleanup_too_many_logs_unittest>
+    -DTEST_DIR=${glog_BINARY_DIR}/
+    -DTEST_SUBDIR=test_subdir/
+    -P ${glog_SOURCE_DIR}/cmake/RunCleanerTestTooManyLogs.cmake
+    WORKING_DIRECTORY ${glog_BINARY_DIR})
 
   # Fixtures setup
   set_tests_properties (cleanup_init PROPERTIES FIXTURES_SETUP logcleanuptest)
@@ -764,6 +776,7 @@ if (BUILD_TESTING)
   set_tests_properties (cleanup_immediately PROPERTIES FIXTURES_REQUIRED logcleanuptest)
   set_tests_properties (cleanup_with_absolute_prefix PROPERTIES FIXTURES_REQUIRED logcleanuptest)
   set_tests_properties (cleanup_with_relative_prefix PROPERTIES FIXTURES_REQUIRED logcleanuptest)
+  set_tests_properties (cleanup_too_many_logs PROPERTIES FIXTURES_REQUIRED logcleanuptest)
 
   add_executable (striplog0_unittest
     src/striplog_unittest.cc

bazel/glog.bzl

@@ -231,6 +231,7 @@ def glog_library(with_gflags = 1, **kwargs):
         "cleanup_immediately",
         "cleanup_with_absolute_prefix",
         "cleanup_with_relative_prefix",
+        "cleanup_too_many_logs",
         # "demangle", # Broken
         # "logging", # Broken
         # "mock-log", # Broken

cmake/RunCleanerTestTooManyLogs.cmake

@@ -0,0 +1,27 @@
+file (TOUCH test_cleanup_info_20240730-111111.2222.toomanylogs)
+file (TOUCH test_cleanup_info_20240730-111112.2222.toomanylogs)
+file (TOUCH test_cleanup_info_20240730-111113.2222.toomanylogs)
+file (TOUCH test_cleanup_info_20240730-111114.2222.toomanylogs)
+execute_process (COMMAND ${LOGCLEANUP} RESULT_VARIABLE _RESULT)
+
+if (NOT _RESULT EQUAL 0)
+  message (FATAL_ERROR "Failed to run logcleanup_unittest (error: ${_RESULT})")
+endif ()
+
+file (GLOB LOG_FILES ${TEST_DIR}/test_cleanup_*.toomanylogs)
+
+if ("test_cleanup_info_20240731-111111.2222.toomanylogs" IN_LIST LOG_FILES)
+  message (SEND_ERROR "Expected old log file to be deleted")
+endif ()
+
+if ("test_cleanup_info_20240731-111112.2222.toomanylogs" IN_LIST LOG_FILES)
+  message (SEND_ERROR "Expected old log file to be deleted")
+endif ()
+
+if ("test_cleanup_info_20240731-111113.2222.toomanylogs" IN_LIST LOG_FILES)
+  message (SEND_ERROR "Expected old log file to be deleted")
+endif ()
+
+if (NOT "test_cleanup_info_20240731-111111.2222.toomanylogs" IN_LIST LOG_FILES)
+  message (SEND_ERROR "Expected newest log file to be retained")
+endif ()

src/cleanup_too_many_logs_unittest.cc

@@ -0,0 +1,96 @@
+// Copyright (c) 2024, Google Inc.
+// All rights reserved.
+//
+// Redistribution and use in source and binary forms, with or without
+// modification, are permitted provided that the following conditions are
+// met:
+//
+//     * Redistributions of source code must retain the above copyright
+// notice, this list of conditions and the following disclaimer.
+//     * Redistributions in binary form must reproduce the above
+// copyright notice, this list of conditions and the following disclaimer
+// in the documentation and/or other materials provided with the
+// distribution.
+//     * Neither the name of Google Inc. nor the names of its
+// contributors may be used to endorse or promote products derived from
+// this software without specific prior written permission.
+//
+// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+#include "base/commandlineflags.h"
+#include "glog/logging.h"
+#include "glog/raw_logging.h"
+#include "googletest.h"
+
+#ifdef GLOG_USE_GFLAGS
+#  include <gflags/gflags.h>
+using namespace GFLAGS_NAMESPACE;
+#endif
+
+#ifdef HAVE_LIB_GMOCK
+#  include <gmock/gmock.h>
+
+#  include "mock-log.h"
+// Introduce several symbols from gmock.
+using google::glog_testing::ScopedMockLog;
+using testing::_;
+using testing::AllOf;
+using testing::AnyNumber;
+using testing::HasSubstr;
+using testing::InitGoogleMock;
+using testing::StrictMock;
+using testing::StrNe;
+#endif
+
+using namespace google;
+
+TEST(CleanTooManyLogs, logging) {
+  using namespace std::chrono_literals;
+  google::EnableLogCleaner(0h);
+  google::SetLogDestination(GLOG_INFO, "test_cleanup_info_");
+  google::SetLogFilenameExtension(".toomanylogs");
+  FLAGS_max_num_log_files = 2;
+
+  LOG(INFO) << "cleanup test";
+
+  google::DisableLogCleaner();
+}
+
+int main(int argc, char** argv) {
+  FLAGS_colorlogtostderr = false;
+  FLAGS_timestamp_in_logfile_name = true;
+#ifdef GLOG_USE_GFLAGS
+  ParseCommandLineFlags(&argc, &argv, true);
+#endif
+  // Make sure stderr is not buffered as stderr seems to be buffered
+  // on recent windows.
+  setbuf(stderr, nullptr);
+
+  // Test some basics before InitGoogleLogging:
+  CaptureTestStderr();
+  const string early_stderr = GetCapturedTestStderr();
+
+  EXPECT_FALSE(IsGoogleLoggingInitialized());
+
+  InitGoogleLogging(argv[0]);
+
+  EXPECT_TRUE(IsGoogleLoggingInitialized());
+
+  InitGoogleTest(&argc, argv);
+#ifdef HAVE_LIB_GMOCK
+  InitGoogleMock(&argc, argv);
+#endif
+
+  // so that death tests run before we use threads
+  CHECK_EQ(RUN_ALL_TESTS(), 0);
+}