luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: shell quote user-provided mailer path (#999)

Browse Source
This commit is contained in:
Sergiu Deitsch 2023-12-21 19:54:07 +01:00 committed by GitHub
parent 716be9edc7
commit d937c2e1b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/logging.cc
View File

@ -2292,13 +2292,17 @@ static bool SendEmailInternal(const char*dest, const char *subject,
subject, body, dest); subject, body, dest);
} }
string logmailer = FLAGS_logmailer; string logmailer;
if (logmailer.empty()) {
if (FLAGS_logmailer.empty()) {
// Don't need to shell escape the literal string
logmailer = "/bin/mail"; logmailer = "/bin/mail";
} else {
logmailer = ShellEscape(FLAGS_logmailer);
} }
string cmd = string cmd =
logmailer + " -s" + logmailer + " -s" + ShellEscape(subject) + " " + ShellEscape(dest);
ShellEscape(subject) + " " + ShellEscape(dest);
if (use_logging) { if (use_logging) {
VLOG(4) << "Mailing command: " << cmd; VLOG(4) << "Mailing command: " << cmd;
} }