luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(symbolize): format unknown stack frames (#1092)

Browse Source
This commit is contained in:
xppt 2024-04-22 22:08:44 +03:00 committed by GitHub
parent c0813f90bb
commit cd4ef77d58
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/symbolize.cc
View File

@ -642,18 +642,13 @@ OpenObjectFileContainingPcAndGetStartAddress(uint64_t pc,
return nullptr; // Malformed line. return nullptr; // Malformed line.
} }
strncpy(out_file_name, cursor, out_file_name_size);
// Making sure |out_file_name| is always null-terminated.
out_file_name[out_file_name_size - 1] = '\0';
// Finally, "cursor" now points to file name of our interest. // Finally, "cursor" now points to file name of our interest.
FileDescriptor object_fd{ return FileDescriptor{
FailureRetry([cursor] { return open(cursor, O_RDONLY); })}; FailureRetry([cursor] { return open(cursor, O_RDONLY); })};
if (!object_fd) {
// Failed to open object file. Copy the object file name to
// |out_file_name|.
strncpy(out_file_name, cursor, out_file_name_size);
// Making sure |out_file_name| is always null-terminated.
out_file_name[out_file_name_size - 1] = '\0';
return nullptr;
}
return object_fd;
} }
} }