luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix double-free in unit test on Windows.

Browse Source 
The LOG_SYSRESULT refers to result twice.  Since, in this test,
result expands to FindClose(handle), the handle was being freed twice.
This commit is contained in:
Robert Hencke 2015-09-06 09:53:22 -04:00
parent a66751870f
commit c10e6ec19c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/logging_unittest.cc
View File

@ -635,7 +635,8 @@ static void GetFiles(const string& pattern, vector<string>* files) {
do { do {
files->push_back(dirname + data.cFileName); files->push_back(dirname + data.cFileName);
} while (FindNextFileA(handle, &data)); } while (FindNextFileA(handle, &data));
LOG_SYSRESULT(FindClose(handle)); BOOL result = FindClose(handle);
LOG_SYSRESULT(result);
#else #else
# error There is no way to do glob. # error There is no way to do glob.
#endif #endif