luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove redundant POSIX function aliases (#990)

Browse Source 
The preprocessor defines interfere with method declarations, e.g., in
std::basic_filebuf, resulting in following error:

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.37.32822\include\fstream(376,26): error C2039: '_close': is not a member of 'std::basic_filebuf<char,std::char_traits<char>>' [D:\a\glog\glog\build_Debug\logging_unittest.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.37.32822\include\iosfwd(244,35): message : see declaration of 'std::basic_filebuf<char,std::char_traits<char>>' [D:\a\glog\glog\build_Debug\logging_unittest.vcxproj]
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.37.32822\include\fstream(375,10): message : while compiling class template member function 'void std::basic_ofstream<char,std::char_traits<char>>::_close(void)' [D:\a\glog\glog\build_Debug\logging_unittest.vcxproj]
D:\a\glog\glog\src\logging_unittest.cc(788,12): message : see the first reference to 'std::basic_ofstream<char,std::char_traits<char>>::_close' in 'TestBasenameAppendWhenNoTimestamp' [D:\a\glog\glog\build_Debug\logging_unittest.vcxproj]
D:\a\glog\glog\src\logging_unittest.cc(786,12): message : see reference to class template instantiation 'std::basic_ofstream<char,std::char_traits<char>>' being compiled [D:\a\glog\glog\build_Debug\logging_unittest.vcxproj]
This commit is contained in:
Sergiu Deitsch 2023-12-19 19:08:48 +01:00 committed by GitHub
parent 931323df21
commit b6082e5088
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/windows/port.h
View File

@ -49,15 +49,16 @@
#define WIN32_LEAN_AND_MEAN /* We always want minimal includes */ #define WIN32_LEAN_AND_MEAN /* We always want minimal includes */
#endif #endif
#include <direct.h> /* for _getcwd() */
#include <io.h> /* because we so often use open/close/etc */
#include <process.h> /* for _getpid() */
#include <windows.h> #include <windows.h>
#include <winsock.h> /* for gethostname */ #include <winsock.h> /* for gethostname */
#include <io.h> /* because we so often use open/close/etc */
#include <direct.h> /* for _getcwd() */ #include <cstdarg> /* template_dictionary.cc uses va_copy */
#include <process.h> /* for _getpid() */ #include <cstdio> /* read in vsnprintf decl. before redefining it */
#include <cstdarg> /* template_dictionary.cc uses va_copy */ #include <cstring> /* for _strnicmp(), strerror_s() */
#include <cstdio> /* read in vsnprintf decl. before redifining it */ #include <ctime> /* for localtime_s() */
#include <cstring> /* for _strnicmp(), strerror_s() */
#include <ctime> /* for localtime_s() */
/* Note: the C++ #includes are all together at the bottom. This file is /* Note: the C++ #includes are all together at the bottom. This file is
* used by both C and C++ code, so we put all the C++ together. * used by both C and C++ code, so we put all the C++ together.
*/ */
@ -80,13 +81,6 @@
/* file I/O */ /* file I/O */
#define PATH_MAX 1024 #define PATH_MAX 1024
#define access _access
#define getcwd _getcwd
#define open _open
#define read _read
#define write(fd, p, n) _write(fd, p, n)
#define lseek _lseek
#define close _close
#define popen _popen #define popen _popen
#define pclose _pclose #define pclose _pclose
#define R_OK 04 /* read-only (for access()) */ #define R_OK 04 /* read-only (for access()) */