luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

stdcxx: eliminate excessive use of std::string::c_str()

Browse Source 
It could be more clear and slightly more efficient not to convert an
`std::string` into a C-style string whenever possible.
This commit is contained in:
Andrei Polushin 2021-12-30 15:41:08 +07:00 committed by Sergiu Deitsch
parent b3abfaa123
commit a8cfbe0c0c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/googletest.h
View File

@ -467,7 +467,7 @@ static inline void StringReplace(string* str,
const string& newsub) { const string& newsub) {
size_t pos = str->find(oldsub); size_t pos = str->find(oldsub);
if (pos != string::npos) { if (pos != string::npos) {
str->replace(pos, oldsub.size(), newsub.c_str()); str->replace(pos, oldsub.size(), newsub);
} }
} }

4
src/logging.cc
View File

@ -1662,7 +1662,7 @@ void LogMessage::Init(const char* file,
char fileline[128]; char fileline[128];
snprintf(fileline, sizeof(fileline), "%s:%d", data_->basename_, line); snprintf(fileline, sizeof(fileline), "%s:%d", data_->basename_, line);
#ifdef HAVE_STACKTRACE #ifdef HAVE_STACKTRACE
if (!strcmp(FLAGS_log_backtrace_at.c_str(), fileline)) { if (FLAGS_log_backtrace_at == fileline) {
string stacktrace; string stacktrace;
DumpStackTraceToString(&stacktrace); DumpStackTraceToString(&stacktrace);
stream() << " (stacktrace:\n" << stacktrace << ") "; stream() << " (stacktrace:\n" << stacktrace << ") ";
@ -2290,7 +2290,7 @@ const vector<string>& GetLoggingDirectories() {
if ( !FLAGS_log_dir.empty() ) { if ( !FLAGS_log_dir.empty() ) {
// A dir was specified, we should use it // A dir was specified, we should use it
logging_directories_list->push_back(FLAGS_log_dir.c_str()); logging_directories_list->push_back(FLAGS_log_dir);
} else { } else {
GetTempDirectories(logging_directories_list); GetTempDirectories(logging_directories_list);
#ifdef GLOG_OS_WINDOWS #ifdef GLOG_OS_WINDOWS