From 831a6f823276216d89daa3b50e2c542c35480e96 Mon Sep 17 00:00:00 2001 From: Rodrigo Queiro Date: Thu, 7 Oct 2021 18:57:24 +0200 Subject: [PATCH] Add -Werror to Bazel presubmits This avoids issues like #717. --- .bazelci/presubmit.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml index 101cd29..31c5690 100644 --- a/.bazelci/presubmit.yml +++ b/.bazelci/presubmit.yml @@ -3,19 +3,23 @@ platforms: ubuntu1804: build_flags: - "--features=layering_check" + - "--copt=-Werror" build_targets: - "//..." test_flags: - "--features=layering_check" + - "--copt=-Werror" test_targets: - "//..." macos: build_flags: - "--features=layering_check" + - "--copt=-Werror" build_targets: - "//..." test_flags: - "--features=layering_check" + - "--copt=-Werror" test_targets: - "//..." windows: @@ -24,9 +28,11 @@ platforms: BAZEL_VC: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC" build_flags: - "--features=layering_check" + - "--copt=/WX" build_targets: - "//..." test_flags: - "--features=layering_check" + - "--copt=/WX" test_targets: - "//..."