luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add override to LogStreamBuf::overflow()

Browse Source 
Prevents warnings such as:
```
glog/logging.h:1122:20: error: ‘virtual
std::basic_streambuf<char>::int_type
google::base_logging::LogStreamBuf::overflow(std::basic_streambuf<char>::int_type)’
can be marked override [-Werror=suggest-override]
   virtual int_type overflow(int_type ch) {
                    ^~~~~~~~
```

Signed-off-by: Santiago Gil <santiago.gil@codethink.co.uk>
This commit is contained in:
Santiago Gil 2020-09-24 10:48:00 +01:00
parent 0a2e5931bd
commit 7258189847
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/glog/logging.h.in
View File

@ -1128,7 +1128,7 @@ class GOOGLE_GLOG_DLL_DECL LogStreamBuf : public std::streambuf {
} }
// This effectively ignores overflow. // This effectively ignores overflow.
virtual int_type overflow(int_type ch) { int_type overflow(int_type ch) {
return ch; return ch;
} }

2
src/windows/glog/logging.h
View File

@ -1129,7 +1129,7 @@ class GOOGLE_GLOG_DLL_DECL LogStreamBuf : public std::streambuf {
} }
// This effectively ignores overflow. // This effectively ignores overflow.
virtual int_type overflow(int_type ch) { int_type overflow(int_type ch) {
return ch; return ch;
} }