luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Move shared headers to a private filegroup

Browse Source
This commit is contained in:
Mai Hussien 2023-04-26 22:23:06 -07:00 committed by Rodrigo Queiro
parent 7a62819e43
commit 4ffdf0dc78
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
bazel/glog.bzl
View File

@ -156,6 +156,16 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
"//conditions:default": [], "//conditions:default": [],
}) })
# Needed to use these headers in `glog` and the test targets without exposing them as public targets in `glog`
native.filegroup(
name = "shared_headers",
srcs = [
"src/base/mutex.h",
"src/stacktrace.h",
"src/utilities.h",
]
)
native.cc_library( native.cc_library(
name = "glog", name = "glog",
visibility = ["//visibility:public"], visibility = ["//visibility:public"],
@ -177,17 +187,15 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
"src/symbolize.h", "src/symbolize.h",
"src/utilities.cc", "src/utilities.cc",
"src/vlog_is_on.cc", "src/vlog_is_on.cc",
":shared_headers",
] + select({ ] + select({
"@bazel_tools//src/conditions:windows": windows_only_srcs, "@bazel_tools//src/conditions:windows": windows_only_srcs,
"//conditions:default": [], "//conditions:default": [],
}), }),
hdrs = [ hdrs = [
"src/base/commandlineflags.h", "src/base/commandlineflags.h",
"src/base/mutex.h",
"src/glog/log_severity.h", "src/glog/log_severity.h",
"src/glog/platform.h", "src/glog/platform.h",
"src/stacktrace.h",
"src/utilities.h",
":logging_h", ":logging_h",
":raw_logging_h", ":raw_logging_h",
":stl_logging_h", ":stl_logging_h",
@ -227,6 +235,7 @@ def glog_library(namespace = "google", with_gflags = 1, **kwargs):
visibility = ["//visibility:public"], visibility = ["//visibility:public"],
srcs = [ srcs = [
":config_h", ":config_h",
":shared_headers",
"src/googletest.h", "src/googletest.h",
"src/" + test_name + "_unittest.cc", "src/" + test_name + "_unittest.cc",
], ],