From 4a40e5e318cb72dbd74a41df3ad7d8b016377206 Mon Sep 17 00:00:00 2001 From: Hari Krishna Sunder Date: Mon, 24 Jun 2024 11:32:25 -0700 Subject: [PATCH] Update docs --- docs/logging.md | 6 ++++-- src/glog/vlog_is_on.h | 7 +++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/docs/logging.md b/docs/logging.md index 48eb3a7..5e3a9dc 100644 --- a/docs/logging.md +++ b/docs/logging.md @@ -247,9 +247,11 @@ The wildcarding functionality 3. supports both `*` (matches 0 or more characters) and `?` (matches any single character) wildcards. Please also refer to [command line flags](flags.md) for more information. +You can dynamically control the level of a module using the `#!cpp SetVLOGLevel` function. + There's also `#!cpp VLOG_IS_ON(n)` "verbose level" condition macro. This macro -returns `#!cpp true` when the `--v` is equal to or greater than `n`. The macro can be -used as follows: +returns `#!cpp true` when the matching `--vmodule`, else `--v` is equal to or greater than `n`. +The macro can be used as follows: ``` cpp if (VLOG_IS_ON(2)) { diff --git a/src/glog/vlog_is_on.h b/src/glog/vlog_is_on.h index 24cb814..a90a409 100644 --- a/src/glog/vlog_is_on.h +++ b/src/glog/vlog_is_on.h @@ -103,10 +103,9 @@ namespace google { // Set VLOG(_IS_ON) level for module_pattern to log_level. // This lets us dynamically control what is normally set by the --vmodule flag. // Returns the level that previously applied to module_pattern. -// NOTE: To change the log level for VLOG(_IS_ON) sites that matched a prior -// --vmodule pattern the exact pattern has to be supplied again. (If no -// --vmodule pattern applied to them before then the first matching pattern will -// start to control them.) +// NOTE: All VLOG(_IS_ON) sites that have not matched any prior module_patterns +// will be re-evaluated with the provided module_pattern. Sites that have +// already matched a different module_pattern will not be affected. extern GLOG_EXPORT int SetVLOGLevel(const char* module_pattern, int log_level); // Various declarations needed for VLOG_IS_ON above: =========================