luo980/glog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tests): prevent clang from optimizing new away (#1017)

Browse Source
This commit is contained in:
Sergiu Deitsch 2024-01-02 13:01:42 +01:00 committed by GitHub
parent b1bc8e75cb
commit 45d7978daf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/logging_unittest.cc
View File

@ -1,4 +1,4 @@
// Copyright (c) 2023, Google Inc. // Copyright (c) 2024, Google Inc.
// All rights reserved. // All rights reserved.
// //
// Redistribution and use in source and binary forms, with or without // Redistribution and use in source and binary forms, with or without
@ -355,10 +355,19 @@ struct NewHook {
~NewHook() { g_new_hook = nullptr; } ~NewHook() { g_new_hook = nullptr; }
}; };
namespace {
int* allocInt() { return new int; }
} // namespace
TEST(DeathNoAllocNewHook, logging) { TEST(DeathNoAllocNewHook, logging) {
// tests that NewHook used below works // tests that NewHook used below works
NewHook new_hook; NewHook new_hook;
ASSERT_DEATH({ new int; }, "unexpected new"); // Avoid unused warnings under MinGW
//
// NOTE MSVC produces warning C4551 here if we do not take the address of the
// function explicitly.
(void)&allocInt;
ASSERT_DEATH({ allocInt(); }, "unexpected new");
} }
void TestRawLogging() { void TestRawLogging() {