luo980/curl
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
A command line tool and library for transferring data with URL syntax, supporting DICT, FILE, FTP, FTPS, GOPHER, GOPHERS, HTTP, HTTPS, IMAP, IMAPS, LDAP, LDAPS, MQTT, POP3, POP3S, RTMP, RTMPS, RTSP, SCP, SFTP, SMB, SMBS, SMTP, SMTPS, TELNET, TFTP, WS and WSS. libcurl offers a myriad of powerful features
33,193 Commits 20 Branches 224 Tags 202 MiB
C 74.8%
Perl 8.1%
M4 4.8%
Python 4.3%
CMake 2.7%
Other 5.3%
eb8ad66f6c
Go to file
Jay Satiro eb8ad66f6c asyn-thread: stop using GetAddrInfoExW on Windows 
- For the threaded resolver backend on Windows, revert back to
  exclusively use the threaded resolver with libcurl-owned threading
  instead of GetAddrInfoExW with Windows-owned threading.

Winsock (the Windows sockets library) has a bug where it does not wait
for all of the name resolver threads it is managing to terminate before
returning from WSACleanup. The threads continue to run and may cause a
crash.

This commit is effectively a revert of several commits that encompass
all GetAddrInfoExW code in libcurl. A manual review of merge conflicts
was used to resolve minor changes that had modified the code for
aesthetic or build reasons in other commits.

Prior to this change if libcurl was built with the threaded resolver
backend for Windows, and Windows 8 or later was the operating system at
runtime, and the caller was not impersonating another user, then libcurl
would use GetAddrInfoExW to handle asynchronous name lookups.

GetAddrInfoExW support was added in a6bbc87f, which preceded 8.6.0, and
prior to that the threaded resolver backend used libcurl-owned threading
exclusively on Windows.

Reported-by: Ionuț-Francisc Oancea
Reported-by: Razvan Pricope

Ref: https://developercommunity.visualstudio.com/t/ASAN:-heap-use-after-free-in-NdrFullPoin/10654169

Fixes https://github.com/curl/curl/issues/13509#issuecomment-2225338110
Closes https://github.com/curl/curl/pull/14794

---

Revert "asyn-thread: avoid using GetAddrInfoExW with impersonation"

This reverts commit 0caadc1f24.

Conflicts:
	lib/system_win32.c

--

Revert "asyn-thread: fix curl_global_cleanup crash in Windows"

This reverts commit 428579f5d1.

--

Revert "system_win32: fix a function pointer assignment warning"

This reverts commit 26f002e02e.

--

Revert "asyn-thread: use GetAddrInfoExW on >= Windows 8"

This reverts commit a6bbc87f9e.

Conflicts:
	lib/asyn-thread.c
	lib/system_win32.c

--
2024-09-08 11:39:30 -04:00
.circleci GHA/macos: improve, fix gcc/llvm, add new test matrix 2024-07-19 12:45:18 +02:00
.github GHA/distcheck: keep upload artifacts for one day only 2024-09-05 23:50:48 +02:00
CMake build: add poll() detection for cross-builds 2024-08-30 17:14:33 +02:00
docs doh: cleanups 2024-09-06 08:58:52 +02:00
include printf: fix mingw-w64 format checks 2024-09-02 21:03:01 +02:00
lib asyn-thread: stop using GetAddrInfoExW on Windows 2024-09-08 11:39:30 -04:00
LICENSES copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
m4 lib: remove use of RANDOM_FILE 2024-09-02 18:42:32 +02:00
packages tests: delete libhostname.so and chkhostname 2024-08-27 23:40:48 +02:00
plan9 copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
projects misc: general C style cleanups 2024-08-22 23:43:45 +02:00
scripts maketgz: fix RELEASE-TOOLS.md for daily tarballs 2024-09-07 09:33:09 -07:00
src Makefile.mk: update to use Markdown sources for manual 2024-09-06 21:57:54 +02:00
tests build: generate buildinfo.txt for test logs 2024-09-06 21:46:04 +02:00
winbuild tidy-up: OS names 2024-08-04 19:17:45 +02:00
.azure-pipelines.yml CI/azure: disable parallel tests, allow IDN tests 2024-08-19 14:09:14 +02:00
.dir-locals.el copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
.git-blame-ignore-revs copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
.gitattributes winbuild: MS-DOS batch tidy-ups 2024-07-02 19:26:15 +02:00
.gitignore CHANGES: rename to CHANGES.md, no longer generated 2024-08-01 13:37:12 +02:00
.mailmap mailmap: Aki Sakurai 2024-08-30 10:28:34 +02:00
acinclude.m4 build: generate buildinfo.txt for test logs 2024-09-06 21:46:04 +02:00
appveyor.sh cmake: show warning if libpsl is not found 2024-08-15 10:38:46 +02:00
appveyor.yml CI: update names of jobs that are now building tests [ci skip] 2024-09-06 17:14:29 +02:00
buildconf copyright: update all copyright lines and remove year ranges 2023-01-03 09:19:21 +01:00
buildconf.bat buildconf.bat: remove outdated groff/nroff use 2024-03-07 22:38:16 +01:00
CHANGES.md CHANGES: rename to CHANGES.md, no longer generated 2024-08-01 13:37:12 +02:00
CMakeLists.txt cmake: fix to show features/protocols with CURL_DISABLE_INSTALL=ON 2024-09-06 21:46:05 +02:00
configure.ac autotools: fix MS-DOS builds 2024-09-06 21:47:35 +02:00
COPYING COPYING: update copyright year 2024-01-08 18:40:06 +01:00
curl-config.in build: tidy up internal macro names for libcurl.pc 2024-08-12 14:56:41 +02:00
Dockerfile maketgz: move from / into scripts 2024-09-05 17:07:41 +02:00
GIT-INFO.md GIT-INFO.md: remove version requirements 2024-07-08 23:06:05 +02:00
libcurl.pc.in build: tidy up internal macro names for libcurl.pc 2024-08-12 14:56:41 +02:00
Makefile.am maketgz: move from / into scripts 2024-09-05 17:07:41 +02:00
Makefile.dist Makefile.dist: fix ca-firefox target 2024-09-06 21:46:05 +02:00
README docs: minor grammar fixes 2022-09-29 10:44:12 +02:00
README.md README: refresh 2024-08-25 23:31:53 +02:00
RELEASE-NOTES RELEASE-NOTES: synced 2024-09-06 08:42:32 +02:00
renovate.json GHA: unify http3 workflows into one 2024-06-01 10:57:23 +02:00
REUSE.toml libcurl.def: move from / into lib 2024-09-05 17:05:40 +02:00
SECURITY.md docs: Clarify OpenSSF Best Practices vs Scorecard 2024-08-22 11:50:20 +02:00

README.md

curl logo

Curl is a command-line tool for transferring data specified with URL syntax. Learn how to use curl by reading the manpage or everything curl.

Find out how to install curl by reading the INSTALL document.

libcurl is the library curl is using to do its job. It is readily available to be used by your software. Read the libcurl manpage to learn how.

Open Source

curl is Open Source and is distributed under an MIT-like license.

Contact

Contact us on a suitable mailing list or use GitHub issues/ pull requests/ discussions.

All contributors to the project are listed in the THANKS document.

Commercial support

For commercial support, maybe private and dedicated help with your problems or applications using (lib)curl visit the support page.

Website

Visit the curl website for the latest news and downloads.

Source code

Download the latest source from the Git server:

git clone https://github.com/curl/curl.git

Security problems

Report suspected security problems via our HackerOne page and not in public.

Notice

Curl contains pieces of source code that is Copyright (c) 1998, 1999 Kungliga Tekniska Högskolan. This notice is included here to comply with the distribution terms.

Backers

Thank you to all our backers! 🙏 Become a backer.

Sponsors

Support this project by becoming a sponsor.