curl/.github/workflows
Viktor Szakats ea98445680
cmake: ENABLE_DEBUG=ON to always set -DDEBUGBUILD
Before this patch `ENABLE_DEBUG=ON` always enabled the TrackMemory
(aka `ENABLE_CURLDEBUG=ON`) feature, but required the `Debug` CMake
configration to actually enable curl debug features
(aka `-DDEBUGBUILD`).

Curl debug features do not require compiling with C debug options. This
also made enabling debug features unintuitive and complicated to use.
Due to other issues (subject to PR #13694) it also caused an error in
default (and `Release`/`MinSizeRel`/`RelWithDebInfo`) configs, when
building the `testdeps` target:
```
ld: CMakeFiles/unit1395.dir/unit1395.c.o: in function `test':
unit1395.c:(.text+0x1a0): undefined reference to `dedotdotify'
```
Ref: https://github.com/curl/curl/actions/runs/9037287098/job/24835990826#step:3:2483

Fix it by always defining `DEBUGBUILD` when setting `ENABLE_DEBUG=ON`.
Decoupling this option from the selected CMake configuration.

Note that after this patch `ENABLE_DEBUG=ON` unconditionally enables
curl debug features. These features are insecure and unsuited for
production. Make sure to omit this option when building for production
in default, `Release` (and other not-`Debug`) modes.

Also delete a workaround no longer necessary in GHA CI jobs.

Ref: 1a62b6e68c (2015-03-03)
Ref: #13583
Closes #13592
2024-05-27 17:57:52 +02:00
..
appveyor-status.yml tidy-up: mostly whitespace nits 2023-08-31 23:02:10 +00:00
awslc.yml ci: update dependency awslabs/aws-lc to v1.28.0 2024-05-25 23:44:36 +02:00
badwords.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
codeql-analysis.yml ci: update github/codeql-action digest to 9fdb3e4 2024-05-24 00:02:03 +02:00
codespell.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
configure-vs-cmake.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
curl-for-win.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
distcheck.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
fuzz.yml appveyor: replace PowerShell with bash + parallel autotools 2023-12-21 22:54:07 +00:00
hacktoberfest-accepted.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
label.yml GHA: pin dependencies 2024-05-15 13:35:45 +02:00
linkcheck.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
linux32.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
linux-old.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
linux.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
macos.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
man-examples.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
ngtcp2-linux.yml CI GHA: add vsftpd to ngtcp2-linux runs 2024-05-23 23:46:06 +02:00
non-native.yml GHA: ignore flaky test 3017 (MQTT) on OpenBSD 2024-05-24 23:47:21 +02:00
osslq-linux.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
proselint.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
quiche-linux.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
reuse.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
shellcheck.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
spellcheck.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
synopsis.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
torture.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00
windows.yml cmake: ENABLE_DEBUG=ON to always set -DDEBUGBUILD 2024-05-27 17:57:52 +02:00
wolfssl.yml GHA: bump actions/checkout from 4.1.4 to 4.1.6 2024-05-22 09:14:10 +02:00