e512fbfa67
Change mingw-w64 printf format checks in public curl headers to use `__MINGW_PRINTF_FORMAT` instead of `gnu_printf`. This syncs the format checker with format string macros published via `curl/system.h`. (Also disable format checks for mingw-w64 older than 3.0.0 (2013-09-20) and classic-mingw, which do not support this macro.) This fixes bogus format checker `-Wformat` warnings in 3rd party code using curl format strings with the curl printf functions, when using mingw-w64 7.0.0 (2019-11-10) and older (with GCC, MSVCRT). It also allows to delete two workaounds for this within curl itself: - setting `-D__USE_MINGW_ANSI_STDIO=1` for mingw-w64 via cmake and configure for `docs/examples` and `tests/http/clients`. Ref:c730c8549b#14640 The format check macro is incompatible (depending on mingw-w64 version and configuration) with the C99 `%z` (`size_t`) format string used internally by curl. To work around this problem, override the format check style in curl public headers to use `gnu_printf`. This is compatible with `%z` in all mingw-w64 versions and allows keeping the C99 format strings internally. Also: - lib/ws.c: add missing space to an error message. - docs/examples/ftpgetinfo.c: fix to use standard printf. Ref: #14643 (take 1) Follow-up to3829759bd0#12489 Closes #14703
86 lines
3.0 KiB
C
86 lines
3.0 KiB
C
#ifndef CURLINC_MPRINTF_H
|
|
#define CURLINC_MPRINTF_H
|
|
/***************************************************************************
|
|
* _ _ ____ _
|
|
* Project ___| | | | _ \| |
|
|
* / __| | | | |_) | |
|
|
* | (__| |_| | _ <| |___
|
|
* \___|\___/|_| \_\_____|
|
|
*
|
|
* Copyright (C) Daniel Stenberg, <daniel@haxx.se>, et al.
|
|
*
|
|
* This software is licensed as described in the file COPYING, which
|
|
* you should have received as part of this distribution. The terms
|
|
* are also available at https://curl.se/docs/copyright.html.
|
|
*
|
|
* You may opt to use, copy, modify, merge, publish, distribute and/or sell
|
|
* copies of the Software, and permit persons to whom the Software is
|
|
* furnished to do so, under the terms of the COPYING file.
|
|
*
|
|
* This software is distributed on an "AS IS" basis, WITHOUT WARRANTY OF ANY
|
|
* KIND, either express or implied.
|
|
*
|
|
* SPDX-License-Identifier: curl
|
|
*
|
|
***************************************************************************/
|
|
|
|
#include <stdarg.h>
|
|
#include <stdio.h> /* needed for FILE */
|
|
#include "curl.h" /* for CURL_EXTERN */
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
#ifndef CURL_TEMP_PRINTF
|
|
#if (defined(__GNUC__) || defined(__clang__) || \
|
|
defined(__IAR_SYSTEMS_ICC__)) && \
|
|
defined(__STDC_VERSION__) && (__STDC_VERSION__ >= 199901L) && \
|
|
!defined(CURL_NO_FMT_CHECKS)
|
|
#if defined(__MINGW32__) && !defined(__clang__)
|
|
#if defined(__MINGW_PRINTF_FORMAT) /* mingw-w64 3.0.0+. Needs stdio.h. */
|
|
#define CURL_TEMP_PRINTF(fmt, arg) \
|
|
__attribute__((format(__MINGW_PRINTF_FORMAT, fmt, arg)))
|
|
#else
|
|
#define CURL_TEMP_PRINTF(fmt, arg)
|
|
#endif
|
|
#else
|
|
#define CURL_TEMP_PRINTF(fmt, arg) \
|
|
__attribute__((format(printf, fmt, arg)))
|
|
#endif
|
|
#else
|
|
#define CURL_TEMP_PRINTF(fmt, arg)
|
|
#endif
|
|
#endif
|
|
|
|
CURL_EXTERN int curl_mprintf(const char *format, ...)
|
|
CURL_TEMP_PRINTF(1, 2);
|
|
CURL_EXTERN int curl_mfprintf(FILE *fd, const char *format, ...)
|
|
CURL_TEMP_PRINTF(2, 3);
|
|
CURL_EXTERN int curl_msprintf(char *buffer, const char *format, ...)
|
|
CURL_TEMP_PRINTF(2, 3);
|
|
CURL_EXTERN int curl_msnprintf(char *buffer, size_t maxlength,
|
|
const char *format, ...)
|
|
CURL_TEMP_PRINTF(3, 4);
|
|
CURL_EXTERN int curl_mvprintf(const char *format, va_list args)
|
|
CURL_TEMP_PRINTF(1, 0);
|
|
CURL_EXTERN int curl_mvfprintf(FILE *fd, const char *format, va_list args)
|
|
CURL_TEMP_PRINTF(2, 0);
|
|
CURL_EXTERN int curl_mvsprintf(char *buffer, const char *format, va_list args)
|
|
CURL_TEMP_PRINTF(2, 0);
|
|
CURL_EXTERN int curl_mvsnprintf(char *buffer, size_t maxlength,
|
|
const char *format, va_list args)
|
|
CURL_TEMP_PRINTF(3, 0);
|
|
CURL_EXTERN char *curl_maprintf(const char *format, ...)
|
|
CURL_TEMP_PRINTF(1, 2);
|
|
CURL_EXTERN char *curl_mvaprintf(const char *format, va_list args)
|
|
CURL_TEMP_PRINTF(1, 0);
|
|
|
|
#undef CURL_TEMP_PRINTF
|
|
|
|
#ifdef __cplusplus
|
|
} /* end of extern "C" */
|
|
#endif
|
|
|
|
#endif /* CURLINC_MPRINTF_H */
|